From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg KH <greg@kroah.com>, David Brownell <david-b@pacbell.net>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv5 3/3] USB: gadget: storage_common: fixed warning building mass storage function
Date: Wed, 28 Jul 2010 16:02:14 +0200 [thread overview]
Message-ID: <op.vgj3x0pp7p4s8u@pikus> (raw)
In-Reply-To: <AANLkTimavNK1cFhOndEBJrz0NWDn+GUYsLkBDEN9XFwr@mail.gmail.com>
On Wed, 28 Jul 2010 15:42:33 +0200, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> 2010/7/28 Michał Nazarewicz <m.nazarewicz@samsung.com>:
>>> Why the warning happens for those two only?
>>> There are two more parameters (four methods) to handle 'ro' and 'file'
>>> which are done in the same way.
>>
>> Those are the only ones that are not used by the mass storage function.
> Now I got it.
>
> I'm just wondering if it somehow useful to append similar parameter to
> that function.
I intend to add it later on when I'll have bit more time. For now just
a quick fix and an entry in my TODO. ;)
--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
next prev parent reply other threads:[~2010-07-28 14:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 12:13 [PATCHv5 1/3] USB: gadget: composite: Better string override handling Michal Nazarewicz
2010-07-28 12:13 ` [PATCHv5 2/3] USB: gadget: Use new composite features in some gadgets Michal Nazarewicz
2010-07-28 12:13 ` [PATCHv5 3/3] USB: gadget: storage_common: fixed warning building mass storage function Michal Nazarewicz
2010-07-28 12:25 ` Andy Shevchenko
2010-07-28 13:02 ` Michał Nazarewicz
2010-07-28 13:42 ` Andy Shevchenko
2010-07-28 14:02 ` Michał Nazarewicz [this message]
2010-07-29 22:21 ` [PATCHv5 2/3] USB: gadget: Use new composite features in some gadgets David Brownell
2010-07-30 16:48 ` Michał Nazarewicz
2010-07-30 16:54 ` Greg KH
2010-07-30 18:57 ` David Brownell
2010-07-30 21:21 ` Greg KH
2010-07-30 22:01 ` David Brownell
2010-07-30 22:16 ` Greg KH
2010-07-30 23:58 ` Xiaofan Chen
2010-08-02 17:14 ` Michał Nazarewicz
2010-08-02 22:52 ` Greg KH
2010-08-04 9:21 ` Michal Nazarewicz
2010-08-01 19:05 ` [PATCHv5 1/3] USB: gadget: composite: Better string override handling David Brownell
2010-08-02 9:48 ` Michał Nazarewicz
2010-08-02 11:26 ` David Brownell
2010-08-02 12:47 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.vgj3x0pp7p4s8u@pikus \
--to=m.nazarewicz@samsung.com \
--cc=andy.shevchenko@gmail.com \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox