public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
To: Greg KH <greg@kroah.com>, David Brownell <david-b@pacbell.net>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dries Van Puymbroeck <Dries.VanPuymbroeck@dekimo.com>,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCHv5 1/3] USB: gadget: composite: Better string override handling
Date: Mon, 02 Aug 2010 14:47:16 +0200	[thread overview]
Message-ID: <op.vgs9s2f17p4s8u@pikus> (raw)
In-Reply-To: <28603.82914.qm@web180301.mail.gq1.yahoo.com>

On Mon, 02 Aug 2010 13:26:05 +0200, David Brownell <david-b@pacbell.net> wrote:

>>> NAK.  You're still hard-wiring an un-managed
>>> serial number.

>> Uh?  I'm not.

> Are too.  There's a line assigning such an
> un-managed number.  Get rid of it instead of
> denying its existence (and then justifying it).

Could you point that line to me, please?  I fail to see it in this
patch...  And it wasn't my intention to allow unmanaged serial number
with this patch, so if there is such code then I must have missed it
somehow.

-- 
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--

      reply	other threads:[~2010-08-02 12:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 12:13 [PATCHv5 1/3] USB: gadget: composite: Better string override handling Michal Nazarewicz
2010-07-28 12:13 ` [PATCHv5 2/3] USB: gadget: Use new composite features in some gadgets Michal Nazarewicz
2010-07-28 12:13   ` [PATCHv5 3/3] USB: gadget: storage_common: fixed warning building mass storage function Michal Nazarewicz
2010-07-28 12:25     ` Andy Shevchenko
2010-07-28 13:02       ` Michał Nazarewicz
2010-07-28 13:42         ` Andy Shevchenko
2010-07-28 14:02           ` Michał Nazarewicz
2010-07-29 22:21   ` [PATCHv5 2/3] USB: gadget: Use new composite features in some gadgets David Brownell
2010-07-30 16:48     ` Michał Nazarewicz
2010-07-30 16:54       ` Greg KH
2010-07-30 18:57         ` David Brownell
2010-07-30 21:21           ` Greg KH
2010-07-30 22:01             ` David Brownell
2010-07-30 22:16               ` Greg KH
2010-07-30 23:58               ` Xiaofan Chen
2010-08-02 17:14         ` Michał Nazarewicz
2010-08-02 22:52           ` Greg KH
2010-08-04  9:21             ` Michal Nazarewicz
2010-08-01 19:05 ` [PATCHv5 1/3] USB: gadget: composite: Better string override handling David Brownell
2010-08-02  9:48   ` Michał Nazarewicz
2010-08-02 11:26     ` David Brownell
2010-08-02 12:47       ` Michał Nazarewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.vgs9s2f17p4s8u@pikus \
    --to=m.nazarewicz@samsung.com \
    --cc=Dries.VanPuymbroeck@dekimo.com \
    --cc=david-b@pacbell.net \
    --cc=greg@kroah.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox