From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
To: David Brownell <david-b@pacbell.net>,
Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv8 04/13] USB: gadget: mass_storage: moved strings handling code to composite
Date: Wed, 18 Aug 2010 03:26:03 +0200 [thread overview]
Message-ID: <op.vhl0xpih7p4s8u@localhost> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1008132019440.23591-100000@netrider.rowland.org>
On Sat, 14 Aug 2010 02:23:42 +0200, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Fri, 13 Aug 2010, David Brownell wrote:
>
>> --- On Fri, 8/13/10, Alan Stern <stern@rowland.harvard.edu> wrote:
>> .> ... based on all
>> > the preceding discussion, I now think the best
>> > approach may be _never
>> > to make up a fake serial number. Use the module
>> > parameter, if any, and
>> > otherwise issue a warning and don't have
>> > a serial number string
>> > descriptor (even though that violates the spec).
>>
>>
>> Agreed, and that's what I had asked for. I didn't
>> see code faking up a serial ... did I miss such?
>
> That code has been present in g_file_storage since the beginning.
> There were some patches earlier which moved the code to a different
> location. I guess you missed it. The current round of patches doesn't
> touch that code.
Yep. I originally moved code from g_file_storage to g_mass_storage (and
g_multi) but after David's objections the patches have been dropped so
currently only g_file_storage has this code.
>> If so, let's see a new patch with no faking.
>
> An extra patch or two would be needed to remove the fake-serial
> generation.
This should be a straightforward patch. If no one else does it
I can post it but it may take up to a month for me to find the time
to work on it.
--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
next prev parent reply other threads:[~2010-08-18 1:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 15:43 [PATCHv8 00/13] Various USB improvements Michal Nazarewicz
2010-08-12 15:43 ` [PATCHv8 01/13] USB: gadget: g_multi: fixed vendor and product ID Michal Nazarewicz
2010-08-12 15:43 ` [PATCHv8 02/13] USB: gadget: g_ffs: " Michal Nazarewicz
2010-08-12 15:43 ` [PATCHv8 03/13] USB: gadget: composite: Better string override handling Michal Nazarewicz
2010-08-12 15:43 ` [PATCHv8 04/13] USB: gadget: mass_storage: moved strings handling code to composite Michal Nazarewicz
2010-08-12 15:43 ` [PATCHv8 05/13] USB: gadget: functionfs: code cleanup Michal Nazarewicz
2010-08-12 15:43 ` [PATCHv8 06/13] USB: gadget: g_multi: moved strings handling code to composite Michal Nazarewicz
2010-08-12 15:43 ` [PATCHv8 07/13] usb: gadget: storage: remove nofua file when unbinding Michal Nazarewicz
2010-08-12 15:43 ` [PATCHv8 08/13] usb: gadget: mass_storage: optional SCSI WRITE FUA bit Michal Nazarewicz
2010-08-12 15:43 ` [PATCHv8 09/13] Revert "USB: gadget: section mismatch warning fixed" Michal Nazarewicz
2010-08-12 15:43 ` [PATCHv8 10/13] usb gadget: don't save bind callback in struct usb_gadget_driver Michal Nazarewicz
2010-08-12 15:43 ` [PATCHv8 11/13] usb gadget: don't save bind callback in struct usb_composite_driver Michal Nazarewicz
2010-08-12 15:43 ` [PATCHv8 12/13] usb gadget: don't save bind callback in struct usb_configuration Michal Nazarewicz
2010-08-12 15:43 ` [PATCHv8 13/13] init.h: add some more documentation to __ref* tags Michal Nazarewicz
2010-08-12 15:48 ` Sam Ravnborg
2010-08-12 15:45 ` [PATCHv8 11/13] usb gadget: don't save bind callback in struct usb_composite_driver Uwe Kleine-König
2010-08-12 22:34 ` [PATCHv8 04/13] USB: gadget: mass_storage: moved strings handling code to composite David Brownell
2010-08-13 15:15 ` Alan Stern
2010-08-13 20:30 ` David Brownell
2010-08-14 0:23 ` Alan Stern
2010-08-18 1:26 ` Michał Nazarewicz [this message]
2010-09-01 21:10 ` [PATCHv8 03/13] USB: gadget: composite: Better string override handling Greg KH
2010-09-01 21:12 ` Greg KH
2010-09-02 0:57 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.vhl0xpih7p4s8u@localhost \
--to=m.nazarewicz@samsung.com \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox