From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932616AbbJOCrf (ORCPT ); Wed, 14 Oct 2015 22:47:35 -0400 Received: from mga11.intel.com ([192.55.52.93]:43244 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932385AbbJOCrc (ORCPT ); Wed, 14 Oct 2015 22:47:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,683,1437462000"; d="scan'208";a="664628014" Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes To: "Richard Cochran" Cc: jeffrey.t.kirsher@intel.com, hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, john.stultz@linaro.org, peterz@infradead.org, x86@kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kevin.b.stanton@intel.com Subject: Re: [PATCH v4 3/4] Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping References: <1444675522-4198-1-git-send-email-christopher.s.hall@intel.com> <1444675522-4198-4-git-send-email-christopher.s.hall@intel.com> <20151013135925.GB5422@localhost.localdomain> Date: Wed, 14 Oct 2015 19:47:32 -0700 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Christopher Hall" Organization: Intel Corporation Message-ID: In-Reply-To: <20151013135925.GB5422@localhost.localdomain> User-Agent: Opera Mail/1.0 (Win32) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Oct 2015 06:59:26 -0700, Richard Cochran wrote: > On Mon, Oct 12, 2015 at 11:45:21AM -0700, Christopher S. Hall wrote: >> >> +struct ptp_sys_offset_precise { >> + unsigned int rsv[4]; /* Reserved for future use. */ >> + struct ptp_clock_time dev; >> + struct ptp_clock_time sys; >> +}; >> + > > Please put the reserved field at the bottom. Also, since we reading > the raw monotonic time under the hood, we might as well return it in Good idea. Thanks, Chris