Re: why no call to add_interrupt_randomness() on PPC?

[Andi Kleen <ak@suse.de>]

Chris Friesen <cfriesen@nortelnetworks.com> writes:

> With all the talk about randomness, I went to see where my current system
> (2.2.19 on PPC) was getting random numbers from.  I was kind of surprised to see
> that there is no call to add_interrupt_randomness() in arch/ppc/kernel/irq.c.
> 
> Does anyone know why this call is not present in ppc_irq_dispatch_handler()? 
> Would it be appropriate for me to make a patch for this?  Who would be the
> appropriate person to send this to?

Nobody except for a few really obscure drivers use SA_SAMPLE_RANDOM
with their interrupt handlers (none on ppc as far as I can see) On
i386 all the gathering is normally done via the keyboard/mouse drivers
and the blk interface. The reason e.g. Macs normally do not gather
entropy is that they're using the new input layer for keyboard and
mouse which for some reason doesn't feed its events into the entropy
pool. I believe Wojtech did a patch for it, but I don't know if it has
been merged into the ppc tree yet.

-Andi