From: Andi Kleen <ak@suse.de>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: patch-2.4.10-pre1
Date: 28 Aug 2001 09:10:43 +0200 [thread overview]
Message-ID: <oupofp0k6bw.fsf@pigdrop.muc.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.21.0108271717110.7131-100000@freak.distro.conectiva.suse.lists.linux.kernel> <Pine.LNX.4.21.0108272254470.7514-100000@freak.distro.conectiva.suse.lists.linux.kernel>
In-Reply-To: Marcelo Tosatti's message of "28 Aug 2001 05:31:51 +0200"
Marcelo Tosatti <marcelo@conectiva.com.br> writes:
> --- linux.orig/fs/buffer.c Mon Aug 27 20:46:36 2001
> +++ linux/fs/buffer.c Mon Aug 27 21:43:35 2001
> @@ -2448,6 +2448,10 @@
> write_unlock(&hash_table_lock);
> spin_unlock(&lru_list_lock);
> if (gfp_mask & __GFP_IO) {
> +#ifdef CONFIG_HIGHMEM
> + if (!(gfp_mask & __GFP_HIGHIO) & PageHighMem(page))
^^
Should clearly be &&
Could be a problem if PageHighMem returns something other than 1 for true.
-Andi
next parent reply other threads:[~2001-08-28 7:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.21.0108271717110.7131-100000@freak.distro.conectiva.suse.lists.linux.kernel>
[not found] ` <Pine.LNX.4.21.0108272254470.7514-100000@freak.distro.conectiva.suse.lists.linux.kernel>
2001-08-28 7:10 ` Andi Kleen [this message]
2001-08-28 5:57 ` patch-2.4.10-pre1 Marcelo Tosatti
2001-08-28 10:53 ` patch-2.4.10-pre1 Hugh Dickins
2001-08-27 20:25 patch-2.4.10-pre1 Linus Torvalds
2001-08-27 19:36 ` patch-2.4.10-pre1 Marcelo Tosatti
2001-08-27 21:31 ` patch-2.4.10-pre1 Linus Torvalds
2001-08-27 20:17 ` patch-2.4.10-pre1 Marcelo Tosatti
2001-08-28 1:59 ` patch-2.4.10-pre1 Marcelo Tosatti
2001-08-27 20:42 ` patch-2.4.10-pre1 Alexander Viro
2001-08-28 8:05 ` patch-2.4.10-pre1 Martin Dalecki
2001-08-27 23:15 ` patch-2.4.10-pre1 Kurt Garloff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=oupofp0k6bw.fsf@pigdrop.muc.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox