Re: patch-2.4.10-pre1

Marcelo Tosatti
2001-08-28T07:25:22Z

On 28 Aug 2001, Andi Kleen wrote:

> Marcelo Tosatti <marcelo@conectiva.com.br> writes:
>
> > --- linux.orig/fs/buffer.c Mon Aug 27 20:46:36 2001
> > +++ linux/fs/buffer.c Mon Aug 27 21:43:35 2001
> > @@ -2448,6 +2448,10 @@
> > write_unlock(&hash_table_lock);
> > spin_unlock(&lru_list_lock);
> > if (gfp_mask & __GFP_IO) {
> > +#ifdef CONFIG_HIGHMEM
> > + if (!(gfp_mask & __GFP_HIGHIO) & PageHighMem(page))
> ^^
> Should clearly be &&
> Could be a problem if PageHighMem returns something other than 1 for true.

Right.

Linus, please fix that on your tree.