From: Andi Kleen <andi@firstfloor.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [patch] x86: test case for the RODATA config option
Date: 23 Jan 2008 10:09:58 +0100 [thread overview]
Message-ID: <p731w88nc0p.fsf@crumb.suse.de> (raw)
In-Reply-To: <20080122144420.4ebcf95f@laptopd505.fenrus.org>
Arjan van de Ven <arjan@infradead.org> writes:
> This patch adds a test module for the DEBUG_RODATA config
> option to make sure change_page_attr() did indeed make
> "const" data read only.
The only that this does that is not done pretty much equivalently
by pageattr-test.c (it just checks G instead of W) is testing the kernel
text mapping on 64bit. On 32bit it is fully redundant I believe.
Testing the kernel mapping might be a good idea, but I would
suggest adding it to pageattr-test.c
Yes I'm sure these basic facts will not stop it from being
applied anyways; just wanted to point it out for the benefit
of the list readers.
-Andi
next prev parent reply other threads:[~2008-01-23 9:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 22:44 [patch] x86: test case for the RODATA config option Arjan van de Ven
2008-01-23 0:04 ` Ingo Molnar
2008-01-23 1:11 ` Nick Piggin
2008-01-23 5:29 ` Arjan van de Ven
2008-01-23 9:09 ` Andi Kleen [this message]
2008-01-23 14:49 ` Arjan van de Ven
2008-01-23 15:27 ` Andi Kleen
2008-01-23 16:04 ` Arjan van de Ven
2008-01-23 16:54 ` Andi Kleen
2008-01-23 17:49 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p731w88nc0p.fsf@crumb.suse.de \
--to=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox