* Avoid printing pointless tsc skew msgs.
@ 2006-04-24 21:52 Dave Jones
2006-04-25 9:35 ` Andi Kleen
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2006-04-24 21:52 UTC (permalink / raw)
To: Linux Kernel
These messages are kinda silly..
CPU#0 had 0 usecs TSC skew, fixed it up.
CPU#1 had 0 usecs TSC skew, fixed it up.
inspired from: http://bugzilla.kernel.org/attachment.cgi?id=7713&action=view
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.16.noarch/arch/i386/kernel/smpboot.c~ 2006-03-29 18:49:23.000000000 -0500
+++ linux-2.6.16.noarch/arch/i386/kernel/smpboot.c 2006-03-29 18:50:35.000000000 -0500
@@ -313,7 +313,8 @@ static void __init synchronize_tsc_bp (v
if (tsc_values[i] < avg)
realdelta = -realdelta;
- printk(KERN_INFO "CPU#%d had %ld usecs TSC skew, fixed it up.\n", i, realdelta);
+ if (realdelta > 0)
+ printk(KERN_INFO "CPU#%d had %ld usecs TSC skew, fixed it up.\n", i, realdelta);
}
sum += delta;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Avoid printing pointless tsc skew msgs.
2006-04-24 21:52 Avoid printing pointless tsc skew msgs Dave Jones
@ 2006-04-25 9:35 ` Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2006-04-25 9:35 UTC (permalink / raw)
To: Dave Jones; +Cc: linux-kernel
Dave Jones <davej@redhat.com> writes:
> These messages are kinda silly..
>
> CPU#0 had 0 usecs TSC skew, fixed it up.
> CPU#1 had 0 usecs TSC skew, fixed it up.
>
> inspired from: http://bugzilla.kernel.org/attachment.cgi?id=7713&action=view
Actually it's not correct because if you fixed it up it won't be 0 usecs
again because of the error it adds
(I'm actually not sure how it even managed to measure 0 usecs)
-Andi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-04-25 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-24 21:52 Avoid printing pointless tsc skew msgs Dave Jones
2006-04-25 9:35 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox