From: Andi Kleen <andi@firstfloor.org>
To: Venki Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
linux-kernel <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org, davej@codemonkey.org.uk,
johnstul@us.ibm.com, mingo@elte.hu, tglx@linutronix.de
Subject: Re: [PATCH] Add support for deferrable timers (respun)
Date: 28 Mar 2007 13:06:35 +0200 [thread overview]
Message-ID: <p734po54og4.fsf@bingen.suse.de> (raw)
In-Reply-To: <20070327204344.GA21529@linux-os.sc.intel.com>
Venki Pallipadi <venkatesh.pallipadi@intel.com> writes:
> +++ new/kernel/timer.c 2007-03-26 15:19:35.000000000 -0800
> @@ -74,7 +74,7 @@
> tvec_t tv3;
> tvec_t tv4;
> tvec_t tv5;
> -} ____cacheline_aligned_in_smp;
> +} ____cacheline_aligned;
Why this change? It should be aligned to 2 bytes anyways.
> static DEFINE_PER_CPU(tvec_base_t *, tvec_bases) = &boot_tvec_bases;
>
> +/*
> + * The lowest bit of base ptr in timer is used as a flag to indicate
> + * 'deferrable' nature of the timer. Functions below help us manage that flag.
> + */
> +static inline unsigned int tbase_get_deferrable(struct tvec_t_base_s *base)
> +{
> + return ((unsigned int)base & TBASE_DEFERRABLE_FLAG);
This will warn on 64bit for cast ptr -> int
-Andi
next prev parent reply other threads:[~2007-03-28 10:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200703212353.l2LNrNOj007453@shell0.pdx.osdl.net>
[not found] ` <20070322140532.GA120@tv-sign.ru>
[not found] ` <20070322151817.GA29840@linux-os.sc.intel.com>
[not found] ` <20070322161355.GA160@tv-sign.ru>
2007-03-27 20:43 ` [PATCH] Add support for deferrable timers (respun) Venki Pallipadi
2007-03-27 21:11 ` Oleg Nesterov
2007-03-27 21:55 ` Venki Pallipadi
2007-03-27 22:22 ` Oleg Nesterov
2007-03-27 22:28 ` Oleg Nesterov
2007-03-27 22:36 ` Venki Pallipadi
2007-03-28 23:00 ` [PATCH] Add support for deferrable timers (respun-Mar28) Venki Pallipadi
2007-03-29 0:01 ` Andrew Morton
2007-03-29 0:59 ` Venki Pallipadi
2007-03-29 11:41 ` Andi Kleen
2007-03-29 11:51 ` Kyle Moffett
2007-03-29 11:58 ` Andi Kleen
2007-03-28 11:06 ` Andi Kleen [this message]
2007-03-28 16:42 ` [PATCH] Add support for deferrable timers (respun) Venki Pallipadi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p734po54og4.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=davej@codemonkey.org.uk \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox