From: Andi Kleen <ak@suse.de>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH: Enable binding to local IPv4 IP address for CIFS file system.
Date: 01 Aug 2006 20:56:26 +0200 [thread overview]
Message-ID: <p734pww2skl.fsf@verdi.suse.de> (raw)
In-Reply-To: <44CF8FCF.6070401@candelatech.com>
Ben Greear <greearb@candelatech.com> writes:
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index 006eb33..1f34c3f 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -118,6 +118,7 @@ struct TCP_Server_Info {
> struct sockaddr_in sockAddr;
> struct sockaddr_in6 sockAddr6;
> } addr;
> + u32 ip4_local_ip; /* if != 0, will bind locally to this IP */
adding a ipv4 only, no ipv6 feature like this at this age seems quite
backwards. If anything you should think of easy expansion to IPv6 at least.
-Andi
prev parent reply other threads:[~2006-08-01 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 17:30 PATCH: Enable binding to local IPv4 IP address for CIFS file system Ben Greear
2006-08-01 18:56 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p734pww2skl.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=greearb@candelatech.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox