From: Andi Kleen <ak@suse.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] Making percpu module variables have their own memory.
Date: 12 Apr 2006 22:23:58 +0200 [thread overview]
Message-ID: <p734q0y4k69.fsf@bragg.suse.de> (raw)
In-Reply-To: <1144869739.26133.74.camel@localhost.localdomain>
Steven Rostedt <rostedt@goodmis.org> writes:
The basic optimization idea looks interesting. But your implementation
is quite complicated.
The basic problem is that extern declarations and definitions
are the same macro. If they weren't one could just use a different
macro depending on if MODULE is defined or not and get rid
of the type comparisons you do.
Since you already need to change a lot of the per CPU definitions how
about you just define a separate macro for extern per cpu
declarations? And then change the basic macro to do the right
thing based on MODULE is set or not.
-Andi
next prev parent reply other threads:[~2006-04-12 20:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-12 19:22 [RFC] Making percpu module variables have their own memory Steven Rostedt
2006-04-12 20:23 ` Andi Kleen [this message]
2006-04-13 1:44 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p734q0y4k69.fsf@bragg.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox