From: Andi Kleen <andi@firstfloor.org>
To: "David J. Wilder" <dwilder@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [Patch 1/2] Trace code and documentation (updated)
Date: 19 Sep 2007 10:30:07 +0200 [thread overview]
Message-ID: <p736427vz00.fsf@bingen.suse.de> (raw)
In-Reply-To: <1190177218.3190.18.camel@lc4eb748232119.ibm.com>
"David J. Wilder" <dwilder@us.ibm.com> writes:
Not having read the whole thing; just something I noticed.
Gut feeling is that you have too many knobs and options and
some overengineering though -- simplifying it would be a good thing.
> +
> +#define TRACE_PRINTF_TMPBUF_SIZE (1024)
> +static char trace_tmpbuf[NR_CPUS][TRACE_PRINTF_TMPBUF_SIZE];
That definitely needs to be a per CPU variable. Imagine
what happens on a NR_CPUS==4096 kernel. In general when
you have a NR_CPUS indexed array you're likely doing something
wrong. Yes there are still places in the main tree who do that,
but most of them need to be fixed.
-Andi
next prev parent reply other threads:[~2007-09-19 8:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 4:46 [Patch 1/2] Trace code and documentation (updated) David J. Wilder
2007-09-19 8:30 ` Andi Kleen [this message]
2007-09-19 14:14 ` David Wilder
2007-09-19 15:38 ` Andi Kleen
2007-09-19 16:20 ` Christoph Hellwig
2007-09-19 16:52 ` Randy Dunlap
2007-09-19 16:55 ` Christoph Hellwig
2007-09-19 17:48 ` Sam Ravnborg
2007-09-19 17:51 ` Christoph Hellwig
2007-09-19 18:01 ` Test harness in the kernel for new syscalls? [Was: Trace code and documentation (updated)] Sam Ravnborg
2007-09-21 4:50 ` Randy Dunlap
2007-09-21 6:33 ` Randy Dunlap
2007-09-21 8:08 ` Christoph Hellwig
2007-09-19 17:41 ` [Patch 1/2] Trace code and documentation (updated) David Wilder
2007-09-23 12:46 ` Christoph Hellwig
2007-09-24 15:16 ` David Wilder
-- strict thread matches above, loose matches on Subject: below --
2007-09-21 21:48 David J. Wilder
2007-09-21 22:23 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p736427vz00.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=dwilder@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox