From: Andi Kleen <andi@firstfloor.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Petr Vandrovec <petr@vandrovec.name>,
discuss@x86-64.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] Fix triplefault on x86-64 bootup
Date: 12 Aug 2007 15:53:57 +0200 [thread overview]
Message-ID: <p73643kkgei.fsf@bingen.suse.de> (raw)
In-Reply-To: <20070812104606.GA5871@martell.zuzino.mipt.ru>
Alexey Dobriyan <adobriyan@gmail.com> writes:
> On Sun, Aug 12, 2007 at 10:12:52AM +0200, Petr Vandrovec wrote:
> > --- a/arch/x86_64/lib/memcpy.S
> > +++ b/arch/x86_64/lib/memcpy.S
> > @@ -124,6 +124,8 @@ ENDPROC(__memcpy)
> > .quad memcpy
> > .quad 1b
> > .byte X86_FEATURE_REP_GOOD
> > - .byte .Lfinal - memcpy
> > + /* Replace only beginning, memcpy is used to apply alternatives, so it
> > + * is silly to overwrite itself with nops - reboot is only outcome... */
> > + .byte 2b - 1b
> > .byte 2b - 1b
> > .previous
>
> Thanks, this fixes E6400 reboots on bootup here.
Please test with only ab144f5ec64c42218a555ec1dbde6b60cf2982d6
applied (or rather a few patches back in the git history)
I bet that fixes it already.
-Andi
next prev parent reply other threads:[~2007-08-12 12:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-12 8:12 [PATCH] Fix triplefault on x86-64 bootup Petr Vandrovec
2007-08-12 8:40 ` Linus Torvalds
2007-08-12 8:59 ` Linus Torvalds
2007-08-12 10:01 ` Andi Kleen
2007-08-12 9:59 ` Andi Kleen
2007-08-12 17:56 ` Linus Torvalds
2007-08-12 9:57 ` [discuss] " Andi Kleen
2007-08-12 10:09 ` Please remove ab144f5ec64c42218a555ec1dbde6b60cf2982d6 was " Andi Kleen
2007-08-12 10:42 ` Petr Vandrovec
2007-08-12 13:55 ` Andi Kleen
2007-08-12 13:46 ` Paolo Ornati
2007-08-12 17:57 ` Linus Torvalds
2007-08-12 10:46 ` Alexey Dobriyan
2007-08-12 13:53 ` Andi Kleen [this message]
2007-08-12 13:12 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73643kkgei.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=adobriyan@gmail.com \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petr@vandrovec.name \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox