From: Andi Kleen <ak@suse.de>
To: rohitseth@google.com
Cc: CKRM-Tech <ckrm-tech@lists.sourceforge.net>,
devel@openvz.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch02/05]: Containers(V2)- Generic Linux kernel changes
Date: 20 Sep 2006 13:27:33 +0200 [thread overview]
Message-ID: <p7364fikcbe.fsf@verdi.suse.de> (raw)
In-Reply-To: <1158718722.29000.50.camel@galaxy.corp.google.com>
Rohit Seth <rohitseth@google.com> writes:
> */
> +#ifdef CONFIG_CONTAINERS
> + struct container_struct *ctn; /* Pointer to container, may be NULL */
> +#endif
I still don't think it's a good idea to add a pointer to struct page for this.
This means any kernel that enables the config would need to carry this significant
overhead, no matter if containers are used to not.
Better would be to store them in some other data structure that is only
allocated on demand or figure out a way to store them in the sometimes
not all used fields in struct page.
BTW your patchkit seems to be also in wrong order in that when 02 is applied
it won't compile.
-Andi
next prev parent reply other threads:[~2006-09-20 11:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 2:18 [patch02/05]: Containers(V2)- Generic Linux kernel changes Rohit Seth
2006-09-20 11:27 ` Andi Kleen [this message]
2006-09-20 16:44 ` Rohit Seth
2006-09-20 18:14 ` Andi Kleen
2006-09-20 18:19 ` Rohit Seth
2006-09-20 18:32 ` Andi Kleen
2006-09-21 0:23 ` Christoph Lameter
2006-09-21 0:37 ` Rohit Seth
2006-09-21 0:41 ` Christoph Lameter
2006-09-21 0:53 ` Rohit Seth
2006-09-21 1:33 ` [ckrm-tech] " Chandra Seetharaman
2006-09-21 22:29 ` Rohit Seth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p7364fikcbe.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rohitseth@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox