From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppc32: Fix sector_t definition with CONFIG_LBD
Date: 29 Mar 2004 10:08:36 +0200 [thread overview]
Message-ID: <p7365co848r.fsf@nielsen.suse.de> (raw)
In-Reply-To: <20040328230351.1a0d0e9c.akpm@osdl.org.suse.lists.linux.kernel>
Andrew Morton <akpm@osdl.org> writes:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > sector_t depends on CONFIG_LBD but include/config.h may not be there
> > thus causing interesting breakage in some places...
>
> Nasty.
>
> > Here's the fix for ppc32 (problem found by Roman Zippel, other archs
> > need a similar fix).
>
> Three of them.
>
> 25-akpm/include/asm-s390/types.h | 2 ++
> 25-akpm/include/asm-sh/types.h | 2 ++
> 25-akpm/include/asm-x86_64/types.h | 2 ++
Please use this change for x86-64 instead.
-Andi
diff -u linux-2.6.5rc2-amd64/include/asm-x86_64/types.h-o linux-2.6.5rc2-amd64/include/asm-x86_64/types.h
--- linux-2.6.5rc2-amd64/include/asm-x86_64/types.h-o 2004-03-21 21:11:54.000000000 +0100
+++ linux-2.6.5rc2-amd64/include/asm-x86_64/types.h 2004-03-29 04:44:24.000000000 +0200
@@ -48,10 +48,8 @@
typedef u64 dma64_addr_t;
typedef u64 dma_addr_t;
-#ifdef CONFIG_LBD
typedef u64 sector_t;
#define HAVE_SECTOR_T
-#endif
#endif /* __ASSEMBLY__ */
next prev parent reply other threads:[~2004-03-29 8:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-29 6:32 [PATCH] ppc32: Fix sector_t definition with CONFIG_LBD Benjamin Herrenschmidt
2004-03-29 7:03 ` Andrew Morton
[not found] ` <20040328230351.1a0d0e9c.akpm@osdl.org.suse.lists.linux.kernel>
2004-03-29 8:08 ` Andi Kleen [this message]
2004-03-29 9:37 ` [PATCH] small change to fget() Eric Dumazet
2004-03-29 13:18 ` [PATCH] ppc32: Fix sector_t definition with CONFIG_LBD Benjamin Herrenschmidt
2004-03-29 10:00 ` Andi Kleen
2004-03-29 13:10 ` Anton Blanchard
2004-03-29 13:19 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2004-03-29 19:02 Michel Roelofs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p7365co848r.fsf@nielsen.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox