From: Andi Kleen <ak@suse.de>
To: Pavel Machek <pavel@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: share COMPATIBLE_IOCTL()s across architectures
Date: 20 Mar 2003 01:08:27 +0100 [thread overview]
Message-ID: <p7365qe5284.fsf@amdsimf.suse.de> (raw)
In-Reply-To: Pavel Machek's message of "20 Mar 2003 00:48:29 +0100"
Pavel Machek <pavel@suse.cz> writes:
> --- linux-test/include/linux/compat_ioctl.h 2003-03-20 00:08:12.000000000 +0100
> +++ linux/include/linux/compat_ioctl.h 2003-03-19 23:36:24.000000000 +0100
> @@ -0,0 +1,641 @@
> +/* List here explicitly which ioctl's are known to have
> + * compatible types passed or none at all...
> + */
> +/* Big T */
> +COMPATIBLE_IOCTL(TCGETA)
Shouldn't you put the include files needed for all that in there too?
Otherwise you have another ugly list to duplicate. The includes
cannot be put inside the ioctl list, because in some extreme
case they can generate code (e.g. when gcc decides to ignore inline
again and emits functions for includes)
It could be done with a special symbol like:
#ifdef DO_INCLUDES
#include foo1
#include foo2
#else
COMPATIBLE_IOCTL(...)
#endif
-Andi
next parent reply other threads:[~2003-03-19 23:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030319232157.GA13415@elf.ucw.cz.suse.lists.linux.kernel>
2003-03-20 0:08 ` Andi Kleen [this message]
2003-03-20 19:33 ` share COMPATIBLE_IOCTL()s across architectures Pavel Machek
2003-03-20 20:26 ` Andi Kleen
2003-03-21 10:24 ` Pavel Machek
[not found] <20030320001013$67af@gated-at.bofh.it>
[not found] ` <20030320001013$68b4@gated-at.bofh.it>
2003-03-20 1:35 ` Arnd Bergmann
2003-03-20 2:38 ` Andi Kleen
2003-03-20 10:30 ` Arnd Bergmann
2003-03-20 19:35 ` Pavel Machek
2003-03-19 23:21 Pavel Machek
2003-03-20 0:01 ` David S. Miller
2003-03-20 19:32 ` Pavel Machek
2003-03-20 20:24 ` Andi Kleen
2003-03-21 10:21 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p7365qe5284.fsf@amdsimf.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox