From: Andi Kleen <ak@suse.de>
To: Prasanna S Panchamukhi <prasanna@in.ibm.com>
Cc: jeffpc@optonline.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][TRIVIAL] Allocate kprobe_table at runtime
Date: 27 Jun 2005 08:14:12 +0200 [thread overview]
Message-ID: <p737jggwcln.fsf@verdi.suse.de> (raw)
In-Reply-To: <20050627055150.GA10659@in.ibm.com.suse.lists.linux.kernel>
Prasanna S Panchamukhi <prasanna@in.ibm.com> writes:
> Jeff,
>
> On Sun, Jun 26, 2005 at 06:37:29PM +0000, Jeff Sipek wrote:
> > Allocates kprobe_table at runtime.
> > - /* FIXME allocate the probe table, currently defined statically */
> > + kprobe_table = kmalloc(sizeof(struct hlist_head)*KPROBE_TABLE_SIZE, GFP_ATOMIC);
>
> Memory allocation using GFP_KERNEL has more chances of success as compared to
> GFP_ATOMIC. Why can't we use GFP_KERNEL here?
I don't see any sense in the change anyways. Just using BSS
should be fine.
Jeff, when you submit a patch you should add a small blurb
describing why you think it is a good idea.
-Andi
next parent reply other threads:[~2005-06-27 6:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050626183049.GA22898@optonline.net.suse.lists.linux.kernel>
[not found] ` <20050627055150.GA10659@in.ibm.com.suse.lists.linux.kernel>
2005-06-27 6:14 ` Andi Kleen [this message]
2005-06-27 13:01 ` [PATCH v2][TRIVIAL] Allocate kprobe_table at runtime Jeff Sipek
2005-06-27 19:52 ` Luca Falavigna
2005-06-26 18:30 [PATCH][TRIVIAL] " Jeff Sipek
2005-06-27 5:51 ` Prasanna S Panchamukhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p737jggwcln.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=jeffpc@optonline.net \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox