From: Andi Kleen <ak@suse.de>
To: David Mosberger <davidm@napali.hpl.hp.com>
Cc: bcrl@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] pageattr update
Date: 13 Jun 2002 18:13:37 +0200 [thread overview]
Message-ID: <p737kl35f7y.fsf@oldwotan.suse.de> (raw)
In-Reply-To: <20020612010443.B1350@redhat.com.suse.lists.linux.kernel> <20020613005238.A17700@averell.suse.lists.linux.kernel> <20020613061246.A7121@redhat.com.suse.lists.linux.kernel> <15624.46508.257287.233406@napali.hpl.hp.com.suse.lists.linux.kernel>
David Mosberger <davidm@napali.hpl.hp.com> writes:
> As long as change_page_attr() is used for AGP-related stuff only,
> there is probably no real issue with the patch in its current form
> (its simply a no-op on most non-x86 platforms). However, I'm a bit
> worried that someone might start to use it for other things, such that
> change_page_attr() could no longer be a no-op on those platforms.
> Since the DMA coherency issue is an AGP specific issue, perhaps just
> renaming the macro to agp_change_page_attr() would take care of my
> concern. What do you think
Linus already requested that for 2.5 (agp_map_into_gart() etc.)
I think for 2.4 #ifdef in the agp code is fine and I'm not adopting Ben's
change of moving change_page_attr into all asm files.
-Andi
next parent reply other threads:[~2002-06-13 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020612010443.B1350@redhat.com.suse.lists.linux.kernel>
[not found] ` <20020613005238.A17700@averell.suse.lists.linux.kernel>
[not found] ` <20020613061246.A7121@redhat.com.suse.lists.linux.kernel>
[not found] ` <15624.46508.257287.233406@napali.hpl.hp.com.suse.lists.linux.kernel>
2002-06-13 16:13 ` Andi Kleen [this message]
2002-06-12 5:04 [patch] pageattr update Benjamin LaHaise
2002-06-12 22:52 ` Andi Kleen
2002-06-13 10:12 ` Benjamin LaHaise
2002-06-13 15:09 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p737kl35f7y.fsf@oldwotan.suse.de \
--to=ak@suse.de \
--cc=bcrl@redhat.com \
--cc=davidm@napali.hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox