public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Rui Saraiva <rmps@joel.ist.utl.pt>
Cc: linux-kernel@vger.kernel.org
Subject: Re: RFC: Trailing blanks in source files
Date: 27 Jan 2004 19:34:02 +0100	[thread overview]
Message-ID: <p73bropfdgl.fsf@nielsen.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0401271544120.27260@joel.ist.utl.pt.suse.lists.linux.kernel>

Rui Saraiva <rmps@joel.ist.utl.pt> writes:

> 	It seems that many files [1] in the Linux source have lines with
> trailing blank (space and tab) characters and some even have formfeed
> characters. Obviously these blank characters aren't necessary.
> 
> 	I wonder if it is a waste of time to send patches that clean the
> source? Those patches will only remove those trailing blank characters and
> will be splitted by maintainer.

A lot of people will hate you for that because you'll break their external
patches without any good reason.

Don't do it.

I'm sure there are lots of other areas where good clean up can be done
without causing problems.

-Andi

       reply	other threads:[~2004-01-27 18:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.58.0401271544120.27260@joel.ist.utl.pt.suse.lists.linux.kernel>
2004-01-27 18:34 ` Andi Kleen [this message]
2004-01-27 18:51   ` RFC: Trailing blanks in source files Joseph D. Wagner
2004-01-27 19:13     ` David Weinehall
2004-01-27 19:18       ` Randy.Dunlap
2004-01-28  0:02         ` Andrew Morton
2004-01-28  3:49           ` jw schultz
2004-01-28  3:55             ` Randy.Dunlap
2004-01-28  4:53               ` Pragnesh Sampat
2004-01-27 19:31       ` Paulo Marques
2004-01-28 22:15         ` Paul Jackson
2004-01-28 22:22           ` David Weinehall
2004-01-27 19:14     ` linux
2004-01-27 15:44 Rui Saraiva
2004-01-27 16:15 ` YOSHIFUJI Hideaki / 吉藤英明
2004-01-27 16:30   ` Bas Mevissen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73bropfdgl.fsf@nielsen.suse.de \
    --to=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmps@joel.ist.utl.pt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox