public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Bodo Eggert <7eggert@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] introduce panic_gently
Date: 06 Jul 2007 14:05:49 +0200	[thread overview]
Message-ID: <p73d4z520v6.fsf@bingen.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0707060034330.18989@be1.lrz>

Bodo Eggert <7eggert@gmx.de> writes:

> If the boot process failes to find init or the root fs, the cause has 
> usually scrolled off the screen, and because of the panic, it can't be 
> reached anymore.
> 
> This patch introduces panic_gently, which will allow to use the scrollback 
> buffer and to reboot, but it can't be called from unsafe context.

The implementation certainly has too much duplicated code. If anything
it needs some common functions.

The problem with keeping interrupts on is that the system might continue
to route packets. This is sometimes quite unexpected for users.

Arguably that's unlikely to be already enabled for missing root,
but in theory initrd could have done it.

I think i would prefer if the normal panic() tried to detect the situations
where this is 

It couldn't detect spinlocks, but interrupts off/interrupt context etc.

-Andi

  parent reply	other threads:[~2007-07-06 11:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-05 23:07 [RFC][PATCH] introduce panic_gently Bodo Eggert
2007-07-06  7:57 ` Clemens Koller
2007-07-06 12:03   ` Andi Kleen
2007-07-06 20:52     ` Oleg Verych
2007-07-06 18:00   ` Chuck Ebbert
2007-07-08 17:24     ` Clemens Koller
2007-07-06 12:05 ` Andi Kleen [this message]
2007-07-06 15:24   ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73d4z520v6.fsf@bingen.suse.de \
    --to=andi@firstfloor.org \
    --cc=7eggert@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox