From: Andi Kleen <ak@suse.de>
To: Derek Fults <dfults@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Allow a hyphenated range in get_options, with cleanup
Date: 31 Oct 2006 22:12:18 +0100 [thread overview]
Message-ID: <p73d588kx59.fsf@verdi.suse.de> (raw)
In-Reply-To: <1162328823.9542.434.camel@lnx-dfults.americas.sgi.com>
Derek Fults <dfults@sgi.com> writes:
> This allows a hyphenated range of positive numbers in the string passed
> to command line helper function, get_options.
> Currently the command line option "isolcpus=" takes as its argument a
> list of cpus.
> Format: <cpu number>,...,<cpu number>
> This can get extremely long when isolating the majority of cpus on a
> large system. Valid values of <cpu_number> include all cpus, 0 to
> "number of CPUs in system - 1".
It would be better if you defined a separate function for this
instead of defining such a weird calling convention.
The common code with get_options could be factored out into a helper.
-Andi
prev parent reply other threads:[~2006-10-31 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-31 21:07 [PATCH] Allow a hyphenated range in get_options, with cleanup Derek Fults
2006-10-31 21:11 ` Randy Dunlap
2006-10-31 21:12 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73d588kx59.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=dfults@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox