Re: [PATCH 4/5] PCI-Express AER implemetation: AER core and aerdriver

Zhang, Yanmin
2006-07-13T02:10:55Z

On Wed, 2006-07-12 at 21:16, Arjan van de Ven wrote:
> > +
> > + struct semaphore rpc_sema; /*
> > + * Semaphore access required to
> > + * access, add, remove, or print AER
> > + * aware devices in this RPC hierarchy
> > + */
>
>
> Hi,
>
> sorry to bug you again..
Any comment is welcome.

> but is there a reason you're introducing a new
> semaphore and not a mutex? From looking at the code it could/should be a
> mutex...
It could be a mutex and be deleted because every root port has its own rpc. workqueue
could guarantee only one keventd will service the work at the same time.