From: Andi Kleen <ak@suse.de>
To: Stephane Eranian <eranian@frankl.hpl.hp.com>
Cc: eranian@hpl.hp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/17] 2.6.17.1 perfmon2 patch for review: PMU context switch
Date: 30 Jun 2006 14:27:16 +0200 [thread overview]
Message-ID: <p73fyhmx1zv.fsf@verdi.suse.de> (raw)
In-Reply-To: <200606230913.k5N9D73v032387@frankl.hpl.hp.com>
Stephane Eranian <eranian@frankl.hpl.hp.com> writes:
> This patch contains the PMU context switch routines.
Description/why/what etc. missing.
<quick look>
This is all unconditionally called at context switch?!??
No way this can be merged. It needs to be zero cost for any process
that doesn't use perfmon and even for those it probably needs
some tuning.
See my earlier mail on how to make it zero cost for i386/x86-64.
Please don't submit such horrible code again.
-Andi
next prev parent reply other threads:[~2006-06-30 12:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 9:13 [PATCH 10/17] 2.6.17.1 perfmon2 patch for review: PMU context switch Stephane Eranian
2006-06-30 12:27 ` Andi Kleen [this message]
2006-06-30 12:36 ` Stephane Eranian
2006-06-30 12:59 ` Andi Kleen
2006-06-30 13:29 ` Stephane Eranian
2006-06-30 13:41 ` Andi Kleen
2006-06-30 14:12 ` Stephane Eranian
2006-06-30 14:33 ` Andi Kleen
2006-06-30 16:02 ` Stephane Eranian
2006-06-30 17:08 ` Andi Kleen
2006-06-30 20:47 ` Stephane Eranian
2006-07-03 9:49 ` Stephane Eranian
2006-07-03 19:25 ` Andi Kleen
2006-07-03 19:22 ` Stephane Eranian
2006-07-03 19:36 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2006-06-30 18:33 Chuck Ebbert
2006-06-30 18:42 ` Andi Kleen
2006-06-30 18:43 ` Stephane Eranian
2006-06-30 20:40 ` Stephane Eranian
2006-06-30 19:17 Chuck Ebbert
2006-06-30 19:37 ` Andi Kleen
2006-07-01 15:21 Chuck Ebbert
2006-07-04 15:28 ` Stephane Eranian
2006-07-06 17:30 Chuck Ebbert
2006-07-06 20:16 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73fyhmx1zv.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=eranian@frankl.hpl.hp.com \
--cc=eranian@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox