From: Andi Kleen <ak@suse.de>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: linux-kernel@vger.kernel.org, kraxel@suse.de
Subject: Re: [patch] SMP alternatives: skip with UP kernels.
Date: 11 May 2006 20:28:09 +0200 [thread overview]
Message-ID: <p73hd3w76x2.fsf@bragg.suse.de> (raw)
In-Reply-To: <200605111622.k4BGMAUn003662@harpo.it.uu.se>
Mikael Pettersson <mikpe@it.uu.se> writes:
> On Thu, 11 May 2006 14:13:22 +0200, Gerd Hoffmann wrote:
> >+ if (0 == (__smp_alt_end - __smp_alt_begin))
> >+ return; /* no tables, nothing to patch (UP kernel) */
>
> That's an unnecessarily obscure way of stating the obvious:
>
> if (__smp_alt_end == __smp_alt_begin)
iirc ISO-C guarantees that symbols have different values and the
optimizer could possibly make use of that fact. So you might actually
need some RELOC_HIDE()s to make this safe.
-Andi
next prev parent reply other threads:[~2006-05-11 18:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-11 16:22 [patch] SMP alternatives: skip with UP kernels Mikael Pettersson
2006-05-11 18:28 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-05-11 21:18 Mikael Pettersson
2006-05-10 0:30 2.6.17-rc3 -- SMP alternatives: switching to UP code Rene Herman
2006-05-10 9:28 ` Gerd Hoffmann
2006-05-10 11:41 ` Rene Herman
2006-05-11 12:13 ` [patch] SMP alternatives: skip with UP kernels Gerd Hoffmann
2006-05-11 21:07 ` Rene Herman
2006-05-12 11:41 ` Gerd Hoffmann
2006-05-15 21:41 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73hd3w76x2.fsf@bragg.suse.de \
--to=ak@suse.de \
--cc=kraxel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox