From: Andi Kleen <ak@suse.de>
To: "Gabor Z. Papp" <gzp@myhost.mynet>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: [PATCH] fix devfs compile problems was Re: Linux v2.5.48
Date: 18 Nov 2002 13:43:49 +0100 [thread overview]
Message-ID: <p73heefujy2.fsf_-_@oldwotan.suse.de> (raw)
In-Reply-To: "Gabor Z. Papp"'s message of "18 Nov 2002 10:12:07 +0100"
"Gabor Z. Papp" <gzp@myhost.mynet> writes:
> fs/devfs/base.c:3033: incompatible types in assignment
> fs/devfs/base.c:3034: incompatible types in assignment
> fs/devfs/base.c: In function `devfs_mkdir':
> fs/devfs/base.c:3063: incompatible types in assignment
> fs/devfs/base.c:3064: incompatible types in assignment
> fs/devfs/base.c:3065: incompatible types in assignment
> fs/devfs/base.c: In function `devfs_mknod':
> fs/devfs/base.c:3132: incompatible types in assignment
> fs/devfs/base.c:3133: incompatible types in assignment
> fs/devfs/base.c:3134: incompatible types in assignment
Side effect from the nsec stat patch.
Here is a patch:
Linus, please consider applying.
-Andi
--- linux-2.5.48-work/fs/devfs/base.c-o 2002-11-18 13:39:07.000000000 +0100
+++ linux-2.5.48-work/fs/devfs/base.c 2002-11-18 13:41:12.000000000 +0100
@@ -3029,9 +3029,9 @@
de->vfs_deletable = TRUE;
de->inode.uid = current->euid;
de->inode.gid = current->egid;
- de->inode.atime = CURRENT_TIME;
- de->inode.mtime = CURRENT_TIME;
- de->inode.ctime = CURRENT_TIME;
+ de->inode.atime = get_seconds();
+ de->inode.mtime = get_seconds();
+ de->inode.ctime = get_seconds();
if ( ( inode = _devfs_get_vfs_inode (dir->i_sb, de, dentry) ) == NULL )
return -ENOMEM;
DPRINTK (DEBUG_DISABLED, "(%s): new VFS inode(%u): %p dentry: %p\n",
@@ -3060,9 +3060,9 @@
return err;
de->inode.uid = current->euid;
de->inode.gid = current->egid;
- de->inode.atime = CURRENT_TIME;
- de->inode.mtime = CURRENT_TIME;
- de->inode.ctime = CURRENT_TIME;
+ de->inode.atime = get_seconds();
+ de->inode.mtime = get_seconds();
+ de->inode.ctime = get_seconds();
if ( ( inode = _devfs_get_vfs_inode (dir->i_sb, de, dentry) ) == NULL )
return -ENOMEM;
DPRINTK (DEBUG_DISABLED, "(%s): new VFS inode(%u): %p dentry: %p\n",
@@ -3129,9 +3129,9 @@
return err;
de->inode.uid = current->euid;
de->inode.gid = current->egid;
- de->inode.atime = CURRENT_TIME;
- de->inode.mtime = CURRENT_TIME;
- de->inode.ctime = CURRENT_TIME;
+ de->inode.atime = get_seconds();
+ de->inode.mtime = get_seconds();
+ de->inode.ctime = get_seconds();
if ( ( inode = _devfs_get_vfs_inode (dir->i_sb, de, dentry) ) == NULL )
return -ENOMEM;
DPRINTK (DEBUG_I_MKNOD, ": new VFS inode(%u): %p dentry: %p\n",
-Andi
next parent reply other threads:[~2002-11-18 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.44.0211172036590.32717-100000@penguin.transmeta.com.suse.lists.linux.kernel>
[not found] ` <66aa.3dd8ae09.31d44@gzp1.gzp.hu.suse.lists.linux.kernel>
2002-11-18 12:43 ` Andi Kleen [this message]
2002-11-19 0:07 [PATCH] fix devfs compile problems was Re: Linux v2.5.48 Adam J. Richter
2002-11-19 0:20 ` Andi Kleen
2002-11-19 1:13 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73heefujy2.fsf_-_@oldwotan.suse.de \
--to=ak@suse.de \
--cc=gzp@myhost.mynet \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox