From: Andi Kleen <andi@firstfloor.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>, Ingo Molnar <mingo@elte.hu>,
Len Brown <lenb@kernel.org>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [patch 1/2] ACPI: disable lower idle C-states across suspend/resume
Date: 01 Oct 2007 12:11:37 +0200 [thread overview]
Message-ID: <p73ir5r6t5y.fsf@bingen.suse.de> (raw)
In-Reply-To: <20070922222118.882356049@linutronix.de>
Thomas Gleixner <tglx@linutronix.de> writes:
>
> +/*
> + * Suspend / resume control
> + */
> +static int acpi_idle_suspend;
> +
> +int acpi_processor_suspend(struct acpi_device * device, pm_message_t state)
> +{
> + acpi_idle_suspend = 1;
> + return 0;
> +}
> +
> +int acpi_processor_resume(struct acpi_device * device)
> +{
> + acpi_idle_suspend = 0;
> + return 0;
> +}
Instead of the ugly global variable you could you could just change
pm_idle back to NULL (= default_idle) and then later restore it.
-Andi
next prev parent reply other threads:[~2007-10-01 10:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-22 22:29 [patch 0/2] suspend/resume regression fixes Thomas Gleixner
2007-09-22 22:29 ` [patch 1/2] ACPI: disable lower idle C-states across suspend/resume Thomas Gleixner
2007-10-01 10:11 ` Andi Kleen [this message]
2007-09-22 22:29 ` [patch 2/2] clockevents: remove the suspend/resume workaround^Wthinko Thomas Gleixner
2007-09-22 22:59 ` [patch 0/2] suspend/resume regression fixes Linus Torvalds
2007-09-22 23:30 ` Thomas Gleixner
2007-09-23 1:20 ` Oleg Verych
2007-09-23 3:11 ` Linus Torvalds
2007-09-23 5:24 ` Mihai Donțu
2007-09-23 12:30 ` Alan Cox
2007-09-23 13:00 ` Mihai Donțu
2007-09-23 14:06 ` Matthew Garrett
2007-09-23 10:29 ` Rafael J. Wysocki
2007-09-28 20:27 ` Mark Lord
2007-09-28 20:33 ` Thomas Gleixner
2007-09-28 21:17 ` Mark Lord
2007-09-28 21:40 ` Rafael J. Wysocki
2007-09-28 21:04 ` Alan Cox
2007-09-29 17:12 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73ir5r6t5y.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox