From: Andi Kleen <andi@firstfloor.org>
To: "Paweł Sikora" <pluto@agmk.net>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: smart gcc inliner...
Date: 27 Mar 2007 18:55:36 +0200 [thread overview]
Message-ID: <p73ircm4odz.fsf@bingen.suse.de> (raw)
In-Reply-To: <46093349.7060401@agmk.net>
Paweł Sikora <pluto@agmk.net> writes:
> Hi,
>
> The recent gcc (3.4/4.x) optimizer inlines functions across
> sections which is definitely not we want, e.g. inlining
> functions from .init.text section.
>
> I think, the `__init' macro needs `noinline' attribute and all
> the `static inline __{dev}init' functions need `inline' attribute
> removal to avoid gcc error (inlining failed, function not inlinable).
>
init functions should only ever be called from other init functions.
So this should not happen. If it happens the annotations need to be fixed.
This is already warned for for modules at build time with pending
patches to do the same for vmlinux.
There are already a couple of patches pending for this and many
went into .21.
-Andi
next prev parent reply other threads:[~2007-03-27 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 15:07 smart gcc inliner Paweł Sikora
2007-03-27 16:55 ` Andi Kleen [this message]
2007-03-28 2:55 ` Jeremy Fitzhardinge
2007-03-30 19:32 ` Adrian Bunk
2007-03-30 19:39 ` Jeremy Fitzhardinge
2007-03-28 2:05 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73ircm4odz.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pluto@agmk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox