public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Steven French" <sfrench@us.ibm.com>,
	torvalds@transmeta.com, linux-kernel@vger.kernel.org,
	jra@samba.org
Subject: Re: [BK PATCH] CIFS filesystem for Linux 2.5
Date: 11 Oct 2002 00:00:32 +0200	[thread overview]
Message-ID: <p73it0aosxr.fsf@oldwotan.suse.de> (raw)
In-Reply-To: David Woodhouse's message of "10 Oct 2002 23:17:56 +0200"

David Woodhouse <dwmw2@infradead.org> writes:

> sfrench@us.ibm.com said:
> >  fs/cifs/md4.c                      |  209 +++
> >  fs/cifs/md5.c                      |  363 +++++
> >  fs/cifs/md5.h                      |   38 
> 
> Unless these are somehow CIFS-specific, they should live in linux/lib/

This would have the disadvantage that they would need to be always compiled into the
kernel, even though it may not need it. And we already have code bloat problems,
no need to make it worse.

Making them modular also isn't good. Each module takes a 4k page at least, so you
would waste a lot of memory because they're smaller than 4k.

As long as they are not used by anything else it's probably best to keep it 
where they are.


-Andi

       reply	other threads:[~2002-10-10 21:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <OFFB04937F.1EAC8996-ON87256C4E.006DA4CF@boulder.ibm.com.suse.lists.linux.kernel>
     [not found] ` <17092.1034284232@passion.cambridge.redhat.com.suse.lists.linux.kernel>
2002-10-10 22:00   ` Andi Kleen [this message]
2002-10-10 20:08 [BK PATCH] CIFS filesystem for Linux 2.5 Steven French
2002-10-10 20:14 ` jra
2002-10-10 21:10 ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73it0aosxr.fsf@oldwotan.suse.de \
    --to=ak@suse.de \
    --cc=dwmw2@infradead.org \
    --cc=jra@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfrench@us.ibm.com \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox