From: Andi Kleen <ak@suse.de>
To: DJ Barrow <dj.barrow@asitatech.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: novice coding in /linux/net/ipv4/util.c From: DJ Barrow <dj.barrow@asitatech.com>
Date: 22 Apr 2002 19:07:38 +0200 [thread overview]
Message-ID: <p73it6j8xwl.fsf@oldwotan.suse.de> (raw)
In-Reply-To: <20020422151025Z314220-22651+13849@vger.kernel.org.suse.lists.linux.kernel>
DJ Barrow <dj.barrow@asitatech.com> writes:
> This textbook peice of novice coding which has existed since 2.2.14.
Even earlier I think
BTW do you call libresolv novice coding too ?
> For those who can't spot the error, please note that this function is
> returning a static string, excellent stuff if you are hoping to reuse the
> same function like the following
> printk("%s %s\n",in_ntoa(addr1),in_ntoa(addr2));
That is why most of networking uses the NIPQUAD macro instead.
Best would be probably to convert the few remaining users of in_ntoa
to NIPQUAD and drop this function.
-Andi
next parent reply other threads:[~2002-04-22 17:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020422151025Z314220-22651+13849@vger.kernel.org.suse.lists.linux.kernel>
2002-04-22 17:07 ` Andi Kleen [this message]
2002-04-22 17:19 ` novice coding in /linux/net/ipv4/util.c From: DJ Barrow <dj.barrow@asitatech.com> DJ Barrow
2002-04-23 14:15 ` David S. Miller
2002-04-22 15:12 DJ Barrow
2002-04-22 15:48 ` Richard B. Johnson
2002-04-22 16:03 ` DJ Barrow
2002-04-22 16:21 ` Ben Greear
2002-04-22 20:32 ` Olaf Titz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73it6j8xwl.fsf@oldwotan.suse.de \
--to=ak@suse.de \
--cc=dj.barrow@asitatech.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox