From: Andi Kleen <andi@firstfloor.org>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
akpm@linux-foundation.org, Yinghai Lu <yhlu.kernel@gmail.com>,
Chandramouli Narayanan <mouli@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm -v5 0/3] i386/x86_64 boot: 32-bit boot protocol
Date: 17 Oct 2007 11:24:43 +0200 [thread overview]
Message-ID: <p73k5pmxfdw.fsf@crumb.suse.de> (raw)
In-Reply-To: <1192611948.17856.39.camel@caritas-dev.intel.com>
"Huang, Ying" <ying.huang@intel.com> writes:
> On Wed, 2007-10-17 at 10:25 +0200, Andi Kleen wrote:
> > "Huang, Ying" <ying.huang@intel.com> writes:
> >
> > > Do you think it is a good idea to check the collision between setup data
> > > and memory area used during kernel boot through bootmem allocator?
> >
> > You can't solve this through bootmem because x86-64 allocates memory
> > in several places before bootmem (using functions in e820.c) Right now
> > this is quite hackish with hard coded areas to avoid conflicts. But I
> > recently had a need to allocate more memory that early too and changed
> > the code to a generic early reservation interface. With that it would
> > be relatively easy to reserve.
>
> Can you tell me what that early reservation interface is? What I find in
> x86_64 that does early memory allocation is alloc_low_page, which gets
> non-conflict memory area through e820 map.
It's a new interface I only recently wrote:
ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/early-reserve
Then you can use early_reserve() and the e820 allocator will not touch
it.
> Because setup data is allocated by bootloader or kernel 16-bit setup
> code, and the e820 map is created there too, the memory area used by
> setup data can be made reserved memory area in e820 map by bootloader or
> kernel 16-bit setup code. This way, they will not be overwritten by
> kernel. Do you think this works.
It has a little of a chicken'n'egg problem because the e820 map will
be actually in the area you want to reserve. But it might work too.
Boot data is normally copied before other allocations in head64.c
If you do variable size boot data that might not work though. And might
be a little fragile overall.
-Andi
next prev parent reply other threads:[~2007-10-17 9:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 5:52 [PATCH -mm -v5 0/3] i386/x86_64 boot: 32-bit boot protocol Huang, Ying
2007-10-15 1:47 ` Huang, Ying
2007-10-17 1:59 ` Huang, Ying
2007-10-17 8:25 ` Andi Kleen
2007-10-17 9:05 ` Huang, Ying
2007-10-17 9:24 ` Andi Kleen [this message]
2007-10-18 6:44 ` Huang, Ying
2007-10-17 9:38 ` Eric W. Biederman
2007-10-18 6:57 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73k5pmxfdw.fsf@crumb.suse.de \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mouli@linux.intel.com \
--cc=yhlu.kernel@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox