From: Andi Kleen <andi@firstfloor.org>
To: "Marcin 'Qrczak' Kowalczyk" <qrczak@knm.org.pl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: _proxy_pda still makes linking modules fail
Date: 12 Mar 2007 02:19:05 +0100 [thread overview]
Message-ID: <p73lki39s3a.fsf@bingen.suse.de> (raw)
In-Reply-To: <1173315479.12472.9.camel@qrnik>
Marcin 'Qrczak' Kowalczyk <qrczak@knm.org.pl> writes:
>
> I've heard that it now builds with gcc-4.2.0 snapshots. This is strange:
> if the problem has been fixed for gcc-4.2.0, why doesn't it work for
> gcc-4.1.2? arch/i386/kernel/vmlinux.lds.S does contain _proxy_pda = 0;
Hmm, it probably needs a EXPORT_SYMBOL. The previous change only
fixed the in kernel build.
Does it work with this patch?
-Andi
Export _proxy_pda for gcc 4.2
The symbol is not actually used, but the compiler unforunately generates
a (unused) reference to it. This can happen even in modules. So export it.
Signed-off-by: Andi Kleen <ak@suse.de>
Index: linux/arch/i386/kernel/i386_ksyms.c
===================================================================
--- linux.orig/arch/i386/kernel/i386_ksyms.c
+++ linux/arch/i386/kernel/i386_ksyms.c
@@ -28,3 +28,5 @@ EXPORT_SYMBOL(__read_lock_failed);
#endif
EXPORT_SYMBOL(csum_partial);
+
+EXPORT_SYMBOL(_proxy_pda);
Index: linux/arch/x86_64/kernel/x8664_ksyms.c
===================================================================
--- linux.orig/arch/x86_64/kernel/x8664_ksyms.c
+++ linux/arch/x86_64/kernel/x8664_ksyms.c
@@ -61,3 +61,4 @@ EXPORT_SYMBOL(empty_zero_page);
EXPORT_SYMBOL(init_level4_pgt);
EXPORT_SYMBOL(load_gs_index);
+EXPORT_SYMBOL(_proxy_pda);
next prev parent reply other threads:[~2007-03-12 0:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 0:57 _proxy_pda still makes linking modules fail Marcin 'Qrczak' Kowalczyk
2007-03-10 15:03 ` Adrian Bunk
2007-03-11 14:06 ` Marcin 'Qrczak' Kowalczyk
2007-03-12 1:19 ` Andi Kleen [this message]
2007-03-12 0:25 ` Jeremy Fitzhardinge
2007-03-12 9:48 ` Andi Kleen
2007-03-12 14:45 ` Jeremy Fitzhardinge
2007-03-12 15:45 ` Andi Kleen
2007-03-12 21:58 ` Rusty Russell
2007-03-13 6:23 ` Rusty Russell
2007-03-13 9:04 ` Paul Mackerras
2007-03-13 15:31 ` Jeremy Fitzhardinge
2007-03-13 23:50 ` Paul Mackerras
2007-03-14 1:12 ` Rusty Russell
2007-03-13 15:57 ` Andi Kleen
2007-03-14 2:17 ` Rusty Russell
2007-03-12 18:47 ` Marcin 'Qrczak' Kowalczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73lki39s3a.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qrczak@knm.org.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox