public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Roland McGrath <roland@redhat.com>
Cc: Jeff Dike <jdike@addtoit.com>, Andrew Morton <akpm@osdl.org>,
	tglx@linutronix.de, hpa@zytor.com,
	Chuck Ebbert <76306.1226@compuserve.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86 - 32-bit ptrace emulation mishandles 6th arg
Date: Sat, 10 Nov 2007 08:13:47 +0100	[thread overview]
Message-ID: <p73mytm1sk4.fsf@bingen.suse.de> (raw)
In-Reply-To: <20071107211222.B95634D0564@magilla.localdomain> (Roland McGrath's message of "Wed\,  7 Nov 2007 13\:12\:22 -0800 \(PST\)")

Roland McGrath <roland@redhat.com> writes:

> Sure has my ACK.  
> I never really understood why my old patch was not taken 2.5 years ago.

If I remember correctly the old patch back then broke some programs,
so it was reverted.

It's certainly ugly that it leaks r9 internals to ptrace.
Also it generates redundant code with CLEAR_RREGS.

-Andi

      parent reply	other threads:[~2007-11-10  7:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 15:48 [PATCH] x86 - 32-bit ptrace emulation mishandles 6th arg Jeff Dike
2007-11-07 21:12 ` Roland McGrath
2007-11-07 23:41   ` Jeff Dike
2007-11-07 23:50     ` Roland McGrath
2007-11-08  0:13   ` Chuck Ebbert
2007-11-10  7:13   ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73mytm1sk4.fsf@bingen.suse.de \
    --to=andi@firstfloor.org \
    --cc=76306.1226@compuserve.com \
    --cc=akpm@osdl.org \
    --cc=hpa@zytor.com \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox