From: Andi Kleen <andi@firstfloor.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Christoph Hellwig <hch@infradead.org>,
Daniel Walker <dwalker@mvista.com>
Subject: Re: [PATCH] dump_stack on panic
Date: Wed, 31 Oct 2007 01:14:04 +0100 [thread overview]
Message-ID: <p73odeg2l9v.fsf@bingen.suse.de> (raw)
In-Reply-To: <1193788979.5623.43.camel@localhost.localdomain> (Steven Rostedt's message of "Tue\, 30 Oct 2007 20\:02\:59 -0400")
Steven Rostedt <rostedt@goodmis.org> writes:
> Is there any reason why we don't do a dump_stack on panic?
One (mostly psychological, but still serious) problem is that stack
dumps make panics always look like kernel bugs. But there are panics
which are definitely not kernel bugs: like the popular cannot mount
root or machine checks or a couple of others.
We do not want users to send all these panics to linux-kernel
and they would if they look too much like kernel bugs.
I think it's in principle a good idea, but only if you
distingush the cases which are not kernel bugs.
e.g. use a different panic() call for them that does not dump.
-Andi
next prev parent reply other threads:[~2007-10-31 0:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 0:02 [PATCH] dump_stack on panic Steven Rostedt
2007-10-31 0:14 ` Andi Kleen [this message]
2007-10-31 0:30 ` Steven Rostedt
2007-10-31 8:15 ` Christoph Hellwig
2007-10-31 10:17 ` Ingo Molnar
2007-10-31 10:41 ` Andi Kleen
2007-10-31 10:58 ` Steven Rostedt
2007-10-31 11:17 ` Andi Kleen
2007-10-31 11:39 ` Steven Rostedt
2007-10-31 11:53 ` Andi Kleen
2007-10-31 14:19 ` Arjan van de Ven
2007-10-31 15:00 ` Steven Rostedt
2007-10-31 16:28 ` Arjan van de Ven
2007-10-31 16:39 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73odeg2l9v.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=dwalker@mvista.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox