Re: [patch 1/5] fail-injection library

Andi Kleen
2006-08-23T12:09:34Z

Akinobu Mita <mita@miraclelinux.com> writes:
> + if (failure_probability(data) == 100 ||
> + INT_MAX / 100 * failure_probability(data) > get_random_int())

I don't think it's a good idea to use get_random_int here. It's a secure
quite heavyweight random simulator that eats up precious entropy.

I would use something simple with an option for the user to specify the seed
(default jiffies maybe) for reproducibility.

e.g. the perfmon patchkit that was just posted had a reasonable simple
pseudo RND for lib/. Maybe you can reuse that.

-Andi