Re: [patch 4/5] fail-injection capability for disk IO

Andi Kleen
2006-08-23T12:07:13Z

Akinobu Mita <mita@miraclelinux.com> writes:
> * @bio: The bio describing the location in memory and on the device.
> @@ -3077,6 +3093,9 @@ end_io:
> if (unlikely(test_bit(QUEUE_FLAG_DEAD, &q->queue_flags)))
> goto end_io;
>
> + if (should_fail(fail_make_request, bio->bi_size))
> + goto end_io;

AFAIK it is reasonably easy to write stacking block drivers.
I think I would prefer a stackable driver instead of this hook.

-Andi