Re: [take12 3/3] kevent: Timer notifications.

Arjan van de Ven
2006-08-21T11:27:43Z

On Mon, 2006-08-21 at 15:18 +0400, Evgeniy Polyakov wrote:
> ]> > + lockdep_set_class(&t->ktimer_storage.lock, &kevent_timer_key);
> >
> > When looking at the kevent_storage_init callers most need to do
> > those lockdep_set_class class. Shouldn't kevent_storage_init just
> > get a "struct lock_class_key *" argument?
>
> It will not work, since inode is used for both socket and inode
> notifications (to save some space in struct sock), lockdep initalization
> is performed on the highest level, so I put it alone.

Call me a cynic, but I'm always a bit sceptical about needing lockdep
annotations like this... Can you explain why you need it in this case,
including the proof that it's safe?