From: Andi Kleen <ak@suse.de>
To: Nikita Danilov <Nikita@Namesys.COM>
Cc: linux-kernel@vger.kernel.org
Subject: Re: reiser4 breaks vmware
Date: 24 Dec 2003 23:15:45 +0100 [thread overview]
Message-ID: <p73pted2772.fsf@verdi.suse.de> (raw)
In-Reply-To: <16361.18888.602000.438746@laputa.namesys.com.suse.lists.linux.kernel>
Nikita Danilov <Nikita@Namesys.COM> writes:
> Exactly. I included it into core.diff by mistake.
> Revert it: http://www.namesys.com/snapshots/2003.12.23/broken-out/do_mmap2-fix.diff.patch
There seem to be some other unnecessary patches in there, like
init_fixmap_vma.diff.patch. I cannot imagine why a file system should
need to change that. Same with spinlock-owner.diff.patch. Is that
really needed? If yes porting it to all architectures will be a lot of
work.
I would suggest separating your debug patches, like page-owner.diff.patch
And your webserver is misconfigured: I thinks READ.ME is a troff
document.
The other changes look reasonable, although a lot of the EXPORT_SYMBOLs
should be probably EXPORT_SYMBOL_GPL and carry some more comments about
their purpose.
-Andi
next parent reply other threads:[~2003-12-24 22:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1072202167.8127.15.camel@localhost.suse.lists.linux.kernel>
[not found] ` <3FE8B765.6000907@vgertech.com.suse.lists.linux.kernel>
[not found] ` <16361.18888.602000.438746@laputa.namesys.com.suse.lists.linux.kernel>
2003-12-24 22:15 ` Andi Kleen [this message]
2003-12-25 9:29 ` reiser4 breaks vmware Nikita Danilov
2003-12-23 17:56 Shawn
2003-12-23 19:21 ` Hans Reiser
2003-12-23 21:45 ` Nuno Silva
2003-12-24 8:09 ` Nikita Danilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73pted2772.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=Nikita@Namesys.COM \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox