From: Andi Kleen <ak@suse.de>
To: Dave Jones <davej@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: backport AMD K7 MCE changes.
Date: 03 Oct 2003 23:08:12 +0200 [thread overview]
Message-ID: <p73pthexc5f.fsf@oldwotan.suse.de> (raw)
In-Reply-To: <20031003205408.GA17829@redhat.com.suse.lists.linux.kernel>
Dave Jones <davej@redhat.com> writes:
> */
> - if(c->x86 == 6 || c->x86 == 15)
> +
> + if(c->x86 == 6 || c->x86 == 15) {
> + startbank = 1;
Can you please add comments to such magic changes ?
I still think we should not do anything without an official errata.
The K7 actually has two MCE enable registers: a mask that is only
supposed to be programmed by the BIOS and works around bugs and the
standardized IA32 register controlled by the OS. I suspect your case
only happens with some buggy BIOS that doesn't program the shadow mask
correctly. This would imply that it would make more sense to test it
and program it correctly based on a known good value.
-Andi
next parent reply other threads:[~2003-10-03 21:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20031003205408.GA17829@redhat.com.suse.lists.linux.kernel>
2003-10-03 21:08 ` Andi Kleen [this message]
2003-10-03 20:54 backport AMD K7 MCE changes Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73pthexc5f.fsf@oldwotan.suse.de \
--to=ak@suse.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox