From: Andi Kleen <ak@suse.de>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: PATCH: Fix crash case
Date: 18 Aug 2006 11:51:39 +0200 [thread overview]
Message-ID: <p73r6ze8j84.fsf@verdi.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0608161938320.20450@yvahk01.tjqt.qr>
Jan Engelhardt <jengelh@linux01.gwdg.de> writes:
> >If we are going to BUG() not panic() here then we should cover the case
> >of the BUG being compiled out
>
> Bug can be compiled out? Ah well I much rather like this patch because of
> the previous busy-looping, heating CPUs unnecessarily. (There was a thread,
> about that, too.)
cpu_relax() is on most CPUs as busy as a ";". This often annoys me
too (in particular in panic) when the CPU fans spin up and machines
become noisy. Maybe we need a portable halt() macro.
-Andi
prev parent reply other threads:[~2006-08-18 9:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-16 16:35 PATCH: Fix crash case Alan Cox
2006-08-16 17:39 ` Jan Engelhardt
2006-08-16 19:10 ` Nick Warne
2006-08-16 19:15 ` Randy.Dunlap
2006-08-16 19:19 ` Nick Warne
2006-08-18 9:51 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73r6ze8j84.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox