public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "Thomas Crowley" <tbcrowley@hotmail.com>
Cc: linux-kernel@vger.kernel.org, gregkh@suse.de, len.brown@intel.com
Subject: Re: 64bit PCI IORESOURCE_MEM bugs
Date: 07 Jul 2005 14:30:42 +0200	[thread overview]
Message-ID: <p73r7eakdcd.fsf@verdi.suse.de> (raw)
In-Reply-To: <BAY21-F20B7CAAB5A3DD44D333948A0D90@phx.gbl.suse.lists.linux.kernel>

"Thomas Crowley" <tbcrowley@hotmail.com> writes:
> 
> 1) in arch/x86_64/kernel/e820.c    the e820_reserve_resources function
> the line if (e820.map[i].addr + e820.map[i].size > 0x100000000ULL)
> makes it so any region that
>      starts below the 4Gig mark but ends above 4Gig mark is ignored.

That is already gone in 2.6.13rc1.

> 2) I am unable to get all of my PCI devices to move there addressing
> from the default values to the hole I have given it.  I am getting
> several errors of the form: "PCI: Cannot allocate resource region 8 of
> bridge 0000:00:07.0".  Some of my devices are moving to the proper
> location.
> Neither the code in drivers/pci/probe.c pci_read_bases which gets the
> default addresses for the resources or /arch/i386/pci/i386.c
> pcibios_allocate_bus_resources check to see if the address that are
> being used are reserved.  They just attempt to allocate the memory and
> fail.  It seams like a check should be made in one of these functions
> and if the resources are reserved then the addresses should be
> changed. (Note: 64 bit uses the i386 pci code that is why I am
> pointing out potential errors in the i386 code)

Yes, that code is quite bad and in need of an overhaul. There 
are other problems in there too. Also the default hole selection
algorithm is not very reliable and some BIOS tend to put 
hidden mappings in there. Most likely it needs more support from ACPI.

> I also noticed the reserve kernel param can only take ints so large
> addresses can not be reserved


What reserve kernel param? mem= certainly supports more than 4GB.

-Andi

       reply	other threads:[~2005-07-07 12:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BAY21-F20B7CAAB5A3DD44D333948A0D90@phx.gbl.suse.lists.linux.kernel>
2005-07-07 12:30 ` Andi Kleen [this message]
2005-07-07 15:44   ` 64bit PCI IORESOURCE_MEM bugs Thomas Crowley
2005-07-06 18:24 Thomas Crowley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73r7eakdcd.fsf@verdi.suse.de \
    --to=ak@suse.de \
    --cc=gregkh@suse.de \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tbcrowley@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox