From: Andi Kleen <andi@firstfloor.org>
To: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix x86_64 TIF_SYSCALL_TRACE race in entry.S
Date: Sat, 27 Oct 2007 21:04:57 +0200 [thread overview]
Message-ID: <p73sl3wnzty.fsf@bingen.suse.de> (raw)
In-Reply-To: <20071027180837.GA18134@Krystal> (Mathieu Desnoyers's message of "Sat\, 27 Oct 2007 14\:08\:37 -0400")
Mathieu Desnoyers <compudj@krystal.dyndns.org> writes:
> We make sure that the thread flag read is coherent between our new test and the ALLWORK_MASK test by first saving it in a register used for both comparisons.
>
That doesn't make sense. If someone is setting those asynchronously you
can always race.
You should really just stop the process like ptrace does before changing
such things.
-Andi
next prev parent reply other threads:[~2007-10-27 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 19:37 Adding TIF_TRACE_KERNEL to x86_64 Mathieu Desnoyers
2007-10-27 18:08 ` [PATCH] Fix x86_64 TIF_SYSCALL_TRACE race in entry.S Mathieu Desnoyers
2007-10-27 19:04 ` Andi Kleen [this message]
2007-10-28 21:15 ` Mathieu Desnoyers
2007-10-28 21:21 ` Andi Kleen
2007-10-28 22:31 ` Mathieu Desnoyers
2007-10-27 19:00 ` Adding TIF_TRACE_KERNEL to x86_64 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73sl3wnzty.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=compudj@krystal.dyndns.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox