From: Andi Kleen <ak@suse.de>
To: "Myaskouvskey, Artiom" <artiom.myaskouvskey@intel.com>
Cc: <linux-kernel@vger.kernel.org>, "Satt, Shai" <shai.satt@intel.com>
Subject: Re: [PATCH 2.6.19-rc5-git2] EFI: mapping memory region of runtime services when using memmap kernel parameter
Date: 13 Nov 2006 15:11:52 +0100 [thread overview]
Message-ID: <p73u013307r.fsf@bingen.suse.de> (raw)
In-Reply-To: <C1467C8B168BCF40ACEC2324C1A2B0740170445A@hasmsx411.ger.corp.intel.com>
"Myaskouvskey, Artiom" <artiom.myaskouvskey@intel.com> writes:
>
> +extern int is_available_memory(efi_memory_desc_t * md);
Never put externs into .c files
The whole approach of including the run time services into
the memory map seems bogus. How about ioremap()ing (or fixmaping) them
on demand instead?
-Andi
next prev parent reply other threads:[~2006-11-13 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-13 9:43 [PATCH 2.6.19-rc5-git2] EFI: mapping memory region of runtime services when using memmap kernel parameter Myaskouvskey, Artiom
2006-11-13 14:11 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-11-13 11:08 Myaskouvskey, Artiom
2006-11-13 16:59 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73u013307r.fsf@bingen.suse.de \
--to=ak@suse.de \
--cc=artiom.myaskouvskey@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shai.satt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox