Re: [PATCH 18/33] x86_64: Kill temp_boot_pmds II

Eric W. Biederman
2006-08-02T05:37:14Z

Andi Kleen <ak@suse.de> writes:

>> It is probably patch 17:
>> "x86_64: Separate normal memory map initialization from the hotplug case"
>
> Ok that messes things up. Actually I think i prefered the previous
> code - it was not that bad as you make it. The two variants.
> are really doing mostly the same. So best you drop that.

All of my complaints are real. But yes I do think a reasonable
case can be made for merging them. In several of the worst cases
simply calling memset before initializing the page is probably
sufficient to remove a test later on.

As that code sits right now you need way too much global context
to understand what is going on. It is the kind of code that cause
obviously correct patches to fail, and I'm clever enough to know
clever code is very dangerous. :)

So before I get back to that I will probably look and see if there
is some more heavy lifting I can do to make that code less of a land mine.

>> I don't see any other patches that touch arch/x86_64/mm/init.c
>> before that. At least not in 2.6.18-rc3, which is the base of
>> my patchset.
>
> I got three patches that touch mm/init.c in my patchkit
> (ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/)
>
> BTW I didn't merge any further patches currently, but might
> after the next round when the current comments are addressed.

Ok. I will take a look.

Having any patches merged on a simple request for comments was a bit of a surprise :)

Eric