Re: [PATCH 9/33] i386 boot: Add serial output support to the decompressor

Eric W. Biederman
2006-08-02T07:15:43Z

Andi Kleen <ak@suse.de> writes:

>
>> The function pointers in the console structure are also a problem.
>> static struct console simnow_console = {
>> .name = "simnow",
>> .write = simnow_write,
>> .flags = CON_PRINTBUFFER,
>> .index = -1,
>> };
>
> Yes just patch them at runtime.

I guess that can work. It's a bit of a pain though.

>> Ideally the code would be setup so you can compile out consoles
>> the user finds uninteresting.
>
> Seems overkill for early_printk

At least compiling completely out probably isn't.
I have had too many times where the size of a bzImage was an important
factor on a project.

>> It is annoying to have to call strlen on all of the strings
>> you want to print..
>
> What strlen?

The strlen that is needed to convert putstr(char *s) into the
write method for the early_printk helpers.

Eric