Re: [PATCH 9/33] i386 boot: Add serial output support to the decompressor

Andi Kleen
2006-08-02T03:10:38Z

> > /* WARNING!!
> > * This code is compiled with -fPIC and it is relocated dynamically
> > * at run time, but no relocation processing is performed.
> > * This means that it is not safe to place pointers in static structures.
> > */

iirc the only static relocation in early_printk is the one to initialize
the console pointers - that could certainly be moved to be at run time.

> lib/string.c might be useful. The fact that the functions are not
> static slightly concerns me. I have a vague memory of non-static
> functions generating relocations for no good reason.

Would surprise me.

-Andi