public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] i386: early pagefault handler
Date: 05 Jul 2006 15:10:11 +0200	[thread overview]
Message-ID: <p73veqcp58s.fsf@verdi.suse.de> (raw)
In-Reply-To: <200607050745_MC3-1-C42B-9937@compuserve.com>

Chuck Ebbert <76306.1226@compuserve.com> writes:

> Page faults during kernel initialization can be hard to diagnose.
> 
> Add a handler that prints the fault address, EIP and top of stack
> when an early page fault happens.

You should do it for all the exceptions then
(except perhaps NMI). Isn't much more work - see the x86-64 code.



> +hlt_loop:
> +	hlt

There are still supported i386 CPUs that don't support HLT and
would recursively fault here.

> +	rep ; nop
> +	jmp 1b

Looks a bit weird to not jump to hlt back again but ok.
The HLT is unlikely to come back anyways because interrupts 
are off.

-Andi

  parent reply	other threads:[~2006-07-05 13:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-05 11:44 [patch] i386: early pagefault handler Chuck Ebbert
2006-07-05 11:47 ` Ingo Molnar
2006-07-05 13:10 ` Andi Kleen [this message]
2006-07-05 16:38   ` H. Peter Anvin
2006-07-05 16:54     ` Linus Torvalds
2006-07-05 18:28       ` Alan Cox
2006-07-05 18:26         ` H. Peter Anvin
2006-07-05 18:41         ` Linus Torvalds
2006-07-05 20:24 ` Linus Torvalds
2006-07-07  2:06 ` Daniel Phillips
2006-07-07  2:51   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73veqcp58s.fsf@verdi.suse.de \
    --to=ak@suse.de \
    --cc=76306.1226@compuserve.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox