From: Andi Kleen <ak@suse.de>
To: Max Asbock <masbock@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Driver for IBM RSA service processor (1/2)
Date: 04 Feb 2004 03:49:35 +0100 [thread overview]
Message-ID: <p73vfmnlfsw.fsf@verdi.suse.de> (raw)
In-Reply-To: <200402021129.53193.masbock@us.ibm.com.suse.lists.linux.kernel>
Max Asbock <masbock@us.ibm.com> writes:
> +
> +#define IBMASM_IOCTL_MAGIC 'f'
> +#define IBMASM_IO_CANCEL _IO(IBMASM_IOCTL_MAGIC, 0)
Can you please move that into some file in include/linux ? IMHO all
ioctls should be in some header, otherwise nobody knows you reserved
the number. Note that ioctl numbers must be unique in Linux. Also it
would be good if you added an
register_ioctl32_conversion(IBMASM_IOCTL_MAGIC, sys_ioctl) or an
COMPATIBLE_IOCTL in compat_ioctl.h for it to make it transparently
work with the 32bit emulation layers.
-Andi
next parent reply other threads:[~2004-02-04 2:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200402021129.53193.masbock@us.ibm.com.suse.lists.linux.kernel>
2004-02-04 2:49 ` Andi Kleen [this message]
2004-02-02 19:29 [PATCH] Driver for IBM RSA service processor (1/2) Max Asbock
2004-02-02 21:29 ` Randy.Dunlap
2004-02-02 22:04 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73vfmnlfsw.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=masbock@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox