From: Andi Kleen <ak@suse.de>
To: Benjamin LaHaise <bcrl@redhat.com>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [RFC] 4KB stack + irq stack for x86
Date: 05 Jun 2002 22:40:39 +0200 [thread overview]
Message-ID: <p73vg8xcvco.fsf@oldwotan.suse.de> (raw)
In-Reply-To: <20020604225539.F9111@redhat.com.suse.lists.linux.kernel> <Pine.LNX.4.44.0206050820100.2941-100000@home.transmeta.com.suse.lists.linux.kernel> <20020605144357.A4697@redhat.com.suse.lists.linux.kernel>
Benjamin LaHaise <bcrl@redhat.com> writes:
> On Wed, Jun 05, 2002 at 08:33:13AM -0700, Linus Torvalds wrote:
> > So, as far as I can tell, we now get a nasty aliasing issue on
> > "current_thread_info()->flags", and information like NEED_RESCHED and
> > SIGPENDING end up being set in the wrong place. They get set on the
> > _interrupt_ thread_info, not the "process native" thread_info.
> >
> > Or did I miss some subtlety?
>
> Ah, you're right. If anyone uses current_thread_info from IRQ context
> it will set the flags in the wrong structure. However, it actually
> works because nobody does that currently: all of the _thread_flag users
preemptive kernels do use current_thread_info() for every spinlock.
this required me to change its implementation on x86-64 from stack
arithmetic to access the base register.
-Andi
next parent reply other threads:[~2002-06-05 20:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020604225539.F9111@redhat.com.suse.lists.linux.kernel>
[not found] ` <Pine.LNX.4.44.0206050820100.2941-100000@home.transmeta.com.suse.lists.linux.kernel>
[not found] ` <20020605144357.A4697@redhat.com.suse.lists.linux.kernel>
2002-06-05 20:40 ` Andi Kleen [this message]
2002-06-05 20:55 ` [RFC] 4KB stack + irq stack for x86 Linus Torvalds
2002-06-06 20:55 Ulrich Weigand
2002-06-06 21:19 ` David Mosberger
2002-06-06 22:10 ` Martin J. Bligh
2002-06-07 0:59 ` William Lee Irwin III
[not found] <OF70FD985F.A9C66B00-ONC1256BD0.0069C993@de.ibm.com.suse.lists.linux.kernel>
2002-06-06 19:49 ` Andi Kleen
2002-06-06 20:27 ` David Mosberger
2002-06-07 11:28 ` Maciej W. Rozycki
-- strict thread matches above, loose matches on Subject: below --
2002-06-06 19:24 Ulrich Weigand
[not found] <mailman.1023370621.16639.linux-kernel2news@redhat.com>
2002-06-06 17:37 ` Pete Zaitcev
2002-06-07 1:06 ` David S. Miller
2002-06-06 13:32 Ulrich Weigand
2002-06-05 2:55 Benjamin LaHaise
2002-06-05 15:33 ` Linus Torvalds
2002-06-05 18:43 ` Benjamin LaHaise
2002-06-05 18:53 ` Linus Torvalds
2002-06-05 21:07 ` Benjamin LaHaise
2002-06-05 22:15 ` Steve Lord
2002-06-05 22:31 ` Benjamin LaHaise
2002-06-05 23:13 ` David S. Miller
2002-06-06 0:24 ` Larry McVoy
2002-06-06 1:15 ` Andi Kleen
2002-06-02 15:52 ` Pavel Machek
2002-06-09 18:50 ` Andi Kleen
2002-06-06 1:42 ` Benjamin LaHaise
2002-06-06 2:30 ` Stephen Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73vg8xcvco.fsf@oldwotan.suse.de \
--to=ak@suse.de \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox