From: Andi Kleen <andi@firstfloor.org>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Print taint info in more places.
Date: Fri, 14 Dec 2007 00:08:46 +0100 [thread overview]
Message-ID: <p73y7byfb0h.fsf@bingen.suse.de> (raw)
In-Reply-To: <20071213224927.GA18639@redhat.com> (Dave Jones's message of "Thu\, 13 Dec 2007 17\:49\:27 -0500")
Dave Jones <davej@redhat.com> writes:
> #define WARN_ON(condition) ({ \
> int __ret_warn_on = !!(condition); \
> if (unlikely(__ret_warn_on)) { \
> - printk("WARNING: at %s:%d %s()\n", __FILE__, \
> - __LINE__, __FUNCTION__); \
> + printk(KERN_ERR "WARNING: at %s:%d %s() (%s)\n", \
> + __FILE__, __LINE__, __FUNCTION__, \
> + print_tainted()); \
> dump_stack(); \
Have you checked how this affects code size? It might be worth it
now to do a out of line helper.
-Andi
next prev parent reply other threads:[~2007-12-13 23:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 22:49 Print taint info in more places Dave Jones
2007-12-13 23:08 ` Andi Kleen [this message]
2007-12-13 23:43 ` Mauricio Mauad Menegaz Filho
2007-12-13 23:52 ` Dave Jones
2007-12-14 0:12 ` Dave Jones
2007-12-14 0:03 ` Adrian Bunk
2007-12-14 0:16 ` Dave Jones
2007-12-14 1:30 ` Dave Jones
2007-12-14 7:25 ` Jeremy Fitzhardinge
2007-12-14 7:55 ` Dave Jones
2007-12-14 15:38 ` Matt Mackall
2007-12-14 16:56 ` Dave Jones
2007-12-14 12:09 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73y7byfb0h.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox