From: Andi Kleen <andi@firstfloor.org>
To: Jan Kara <jack@suse.cz>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, npiggin@suse.de
Subject: Re: [PATCH] Improve heuristic detecting sequential reads
Date: 11 Apr 2007 00:56:51 +0200 [thread overview]
Message-ID: <p73y7kzj0ss.fsf@bingen.suse.de> (raw)
In-Reply-To: <20070410155411.GF13445@duck.suse.cz>
Jan Kara <jack@suse.cz> writes:
> Hello!
>
> In thread http://lkml.org/lkml/2007/3/9/403, we discussed a problem
> with the current heuristic for detecting sequential IO in
> do_generic_mapping_read() - for small files a page is marked as accessed
> only once which can cause a performance problems.
> Attached is a patch that improves the heuristic by introducing a
> ra.offset variable so now we can reliably detect sequetial reads.
> The patch replaces Nick's patch from http://lkml.org/lkml/2007/3/15/177
> (Nick has acked to replace the patch). Could you please put the patch
> into -mm?
There's a much more complete patchkit for this that gets reposted
regularly on l-k. Perhaps it would make sense to test that first?
-Andi
next prev parent reply other threads:[~2007-04-10 21:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 15:54 [PATCH] Improve heuristic detecting sequential reads Jan Kara
2007-04-10 22:56 ` Andi Kleen [this message]
2007-04-10 23:45 ` Andrew Morton
[not found] ` <20070411035448.GA4724@mail.ustc.edu.cn>
2007-04-11 3:54 ` WU Fengguang
2007-04-11 10:20 ` Andi Kleen
2007-04-11 2:27 ` Andrew Morton
2007-04-11 12:17 ` Jan Kara
2007-04-12 15:57 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73y7kzj0ss.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox