From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753758AbbIMOxr (ORCPT ); Sun, 13 Sep 2015 10:53:47 -0400 Received: from plane.gmane.org ([80.91.229.3]:58644 "EHLO plane.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753319AbbIMOxW (ORCPT ); Sun, 13 Sep 2015 10:53:22 -0400 X-Injected-Via-Gmane: http://gmane.org/ To: linux-kernel@vger.kernel.org From: Holger =?iso-8859-1?q?Hoffst=E4tte?= Subject: Re: [PATCH 1/2] btrfs: avoid passing int param to start_transaction which takes u64 Date: Sun, 13 Sep 2015 14:53:14 +0000 (UTC) Message-ID: References: <20150913142941.GA7154@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: p4ff58f87.dip0.t-ipconnect.de User-Agent: Pan/0.139 (Sexual Chocolate; GIT bf56508 git://git.gnome.org/pan2) Cc: linux-btrfs@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 13 Sep 2015 14:29:41 +0000, Alexandru Moise wrote: > Signed-off-by: Alexandru Moise <00moses.alexander00@gmail.com> > --- > fs/btrfs/transaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c > index 8f259b3..8a83acd 100644 > --- a/fs/btrfs/transaction.c > +++ b/fs/btrfs/transaction.c > @@ -570,7 +570,7 @@ reserve_fail: > } > > struct btrfs_trans_handle *btrfs_start_transaction(struct btrfs_root *root, > - int num_items) > + u64 num_items) > { > return start_transaction(root, num_items, TRANS_START, > BTRFS_RESERVE_FLUSH_ALL); So I tried to build this..you won't believe what happened next: CC [M] fs/btrfs/transaction.o fs/btrfs/transaction.c:570:28: error: conflicting types for 'btrfs_start_transaction' struct btrfs_trans_handle *btrfs_start_transaction(struct btrfs_root *root, ^ In file included from fs/btrfs/transaction.c:28:0: fs/btrfs/transaction.h:186:28: note: previous declaration of 'btrfs_start_transaction' was here struct btrfs_trans_handle *btrfs_start_transaction(struct btrfs_root *root, ^ scripts/Makefile.build:258: recipe for target 'fs/btrfs/transaction.o' failed You need to update transaction.h as well. -h