public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Bryan O'Sullivan" <bos@pathscale.com>
To: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: [PATCH 0 of 20] [RFC] ipath - PathScale InfiniPath driver
Date: Wed, 28 Dec 2005 16:31:19 -0800	[thread overview]
Message-ID: <patchbomb.1135816279@eng-12.pathscale.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1977 bytes --]

Following Roland's submission of our InfiniPath InfiniBand HCA driver
earlier this month, we have responded to people's comments by making a
large number of changes to the driver.

Here is another set of driver patches for review.  Roland is on
vacation until January 4, so I'm posting these in his place.  Once
again, your comments are appreciated.  We'd like to submit this driver
for inclusion in 2.6.16, so we'll be responding quickly to all
feedback.

A short summary of the changes we have made is as follows:

  - sparse annotations (yes, it passes "make C=1")

  - Removed x86_64 specificity from driver

  - Introduced generic memcpy_toio32 for safe MMIO access

  - Got rid of release and RCS IDs

  - Use set_page_dirty_lock instead of SetPageDirty

  - Fixed misuse of copy_from_user

  - Removed all sysctls

  - Removed stuff inside #ifndef __KERNEL__

  - Use ALIGN() instead of round_up()

  - Use static inlines instead of #defines, generally tidied inline
    functions

  - Renamed _BITS_PER_BYTE to BITS_PER_BYTE, and moved it into
    linux/types.h

  - Got rid of ipath_shortcopy

  - Use fixed-size types for user/kernel communication

  - Renamed ipath_mlock to ipath_get_user_pages, fixed some bugs

There are a few requested changes we have chosen to omit for now:

  - The driver still uses EXPORT_SYMBOL, for consistency with other
    code in drivers/infiniband

  - Someone asked for the kernel's i2c infrastructure to be used, but
    our i2c usage is very specialised, and it would be more of a mess
    to use the kernel's

  - We're still using ioctls instead of sysfs or configfs in some
    cases, to maintain userspace compatibility

Please note that these patches require a set of OpenIB kernel patches
that are awaiting the 2.6.16 submission window in order to compile; in
other words, they really are for review only.  I'll be happy to
provide a suitable jumbo OpenIB patch to anyone who feels a need to
compile-test these patches.

	<b

             reply	other threads:[~2005-12-29  0:43 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-29  0:31 Bryan O'Sullivan [this message]
2005-12-29  0:31 ` [PATCH 1 of 20] Introduce __memcpy_toio32 Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 2 of 20] memcpy32 for x86_64 Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 3 of 20] Add memcpy_toio32 to each arch Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 4 of 20] Define BITS_PER_BYTE Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 5 of 20] ipath - driver core header files Bryan O'Sullivan
2005-12-29  8:18   ` Pekka Enberg
2005-12-29 14:15     ` Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 6 of 20] ipath - driver debugging headers Bryan O'Sullivan
2005-12-29  8:22   ` Pekka Enberg
2005-12-29  0:31 ` [PATCH 7 of 20] ipath - MMIO copy routines Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 8 of 20] ipath - core driver, part 1 of 4 Bryan O'Sullivan
2005-12-30  8:39   ` Greg KH
2005-12-30 23:47     ` Bryan O'Sullivan
2005-12-31  0:12       ` Greg KH
2005-12-29  0:31 ` [PATCH 9 of 20] ipath - core driver, part 2 " Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 10 of 20] ipath - core driver, part 3 " Bryan O'Sullivan
2005-12-30 18:46   ` Linus Torvalds
2005-12-30 23:50     ` Bryan O'Sullivan
2005-12-31  8:36       ` Arjan van de Ven
2005-12-29  0:31 ` [PATCH 11 of 20] ipath - core driver, part 4 " Bryan O'Sullivan
2005-12-29  2:19   ` [openib-general] " Roland Dreier
2005-12-29 14:21     ` Bryan O'Sullivan
2005-12-30  8:12   ` Greg KH
2005-12-30 23:17     ` Bryan O'Sullivan
2005-12-31  0:08       ` Greg KH
2005-12-29  0:31 ` [PATCH 12 of 20] ipath - misc driver support code Bryan O'Sullivan
2005-12-30  8:25   ` Greg KH
2005-12-30 23:10     ` Bryan O'Sullivan
2005-12-31  0:13       ` Greg KH
2005-12-30 18:15   ` Arjan van de Ven
2005-12-29  0:31 ` [PATCH 13 of 20] ipath - routines used by upper layer driver code Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 14 of 20] ipath - infiniband verbs header Bryan O'Sullivan
2005-12-29  8:21   ` Pekka Enberg
2005-12-29 14:22     ` Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 15 of 20] ipath - infiniband verbs support, part 1 of 3 Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 16 of 20] path - infiniband verbs support, part 2 " Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 17 of 20] ipath - infiniband verbs support, part 3 " Bryan O'Sullivan
2005-12-29 19:24   ` Pekka Enberg
2005-12-30  3:19     ` Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 18 of 20] ipath - infiniband management datagram support Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 19 of 20] ipath - kbuild infrastructure Bryan O'Sullivan
2005-12-29  0:31 ` [PATCH 20 of 20] ipath - integrate driver into infiniband " Bryan O'Sullivan
2005-12-29 19:01 ` [PATCH 0 of 20] [RFC] ipath - PathScale InfiniPath driver Horst von Brand
2005-12-29 19:26   ` Lee Revell
2005-12-31  5:36     ` Jan Engelhardt
2006-01-02 16:05     ` Horst von Brand
2006-01-02 16:22       ` Christoph Hellwig
2005-12-30  3:17   ` Bryan O'Sullivan
2005-12-30  8:00 ` Greg KH
2005-12-30 23:11   ` Bryan O'Sullivan
2005-12-31  0:10     ` Greg KH
2005-12-31  1:40       ` Bryan O'Sullivan
2006-01-02 20:35         ` Eric W. Biederman
2006-01-02 22:22           ` Bryan O'Sullivan
2006-01-04 21:26           ` Roland Dreier
2006-01-05 15:28             ` Bryan O'Sullivan
2006-01-03 17:27         ` Greg KH
2006-01-03 20:54           ` Bryan O'Sullivan
2006-01-03 20:57             ` Arjan van de Ven
2006-01-03 21:24               ` Bryan O'Sullivan
2006-01-03 21:26                 ` Arjan van de Ven
2006-01-04  3:33                   ` Bryan O'Sullivan
2006-01-04 21:28             ` [openib-general] " Roland Dreier
2006-01-05 15:31               ` Bryan O'Sullivan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=patchbomb.1135816279@eng-12.pathscale.com \
    --to=bos@pathscale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openib-general@openib.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox